Sign upLogin

drapergeek/findit

View on GitHub
Star

Showing 5 of 5 total issues

Method tab_link has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def tab_link(name, path, controller_name, current_controller, first=nil)
Severity: Minor
Found in app/helpers/layout_helper.rb - About 35 mins to fix

    Method sidebar_list_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def sidebar_list_item(name, open, resolved, action, user=nil)
    Severity: Minor
    Found in app/helpers/tickets_helper.rb - About 35 mins to fix

      Method sortable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def sortable(column, title=nil)
    title ||=column.titleize
    css_class = column == sort_column ? "currecnt #{sort_direction}" :nil
    direction = column == sort_column && sort_direction == "asc" ? "desc" : "asc"
    link_to title, params.merge(:sort=>column, :direction=>direction, :page=>nil), {:class=>css_class}
      Severity: Minor
      Found in app/helpers/application_helper.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def update
    @user = User.find(params[:id])
    if @user.update_attributes(params[:user])
      flash[:notice] = "Successfully updated user."
      redirect_to @user
      Severity: Minor
      Found in app/controllers/users_controller.rb and 1 other location - About 15 mins to fix
      app/controllers/dns_names_controller.rb on lines 29..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def update
    @dns_name = DnsName.find(params[:id])
    if @dns_name.update_attributes(params[:dns_name])
      flash[:notice] = "Successfully updated dns name."
      redirect_to @dns_name
      Severity: Minor
      Found in app/controllers/dns_names_controller.rb and 1 other location - About 15 mins to fix
      app/controllers/users_controller.rb on lines 27..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language