Sign upLogin

drapergeek/findit

View on GitHub
Star

Showing 3 of 5 total issues

Method tab_link has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def tab_link(name, path, controller_name, current_controller, first=nil)
Severity: Minor
Found in app/helpers/layout_helper.rb - About 35 mins to fix

    Method sidebar_list_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def sidebar_list_item(name, open, resolved, action, user=nil)
    Severity: Minor
    Found in app/helpers/tickets_helper.rb - About 35 mins to fix

      Method sortable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def sortable(column, title=nil)
    title ||=column.titleize
    css_class = column == sort_column ? "currecnt #{sort_direction}" :nil
    direction = column == sort_column && sort_direction == "asc" ? "desc" : "asc"
    link_to title, params.merge(:sort=>column, :direction=>direction, :page=>nil), {:class=>css_class}
      Severity: Minor
      Found in app/helpers/application_helper.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language