Sign upLogin

drhenner/ror_ecommerce

View on GitHub
Star
app/controllers/admin/shopping/checkout/base_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Avoid too many return statements within this method.
Open

      return admin_shopping_checkout_shipping_methods_url()
Severity: Major
Found in app/controllers/admin/shopping/checkout/base_controller.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return nil #admin_shopping_carts_url()
    Severity: Major
    Found in app/controllers/admin/shopping/checkout/base_controller.rb - About 30 mins to fix

      Method find_or_create_order has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def find_or_create_order
    return @session_admin_order if @session_admin_order
    if session[:order_admin_id]
      @session_admin_order = checkout_user.orders.include_checkout_objects.find_by_id(session[:order_admin_id])
      create_order if !@session_admin_order || !@session_admin_order.in_progress?
      Severity: Minor
      Found in app/controllers/admin/shopping/checkout/base_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method next_admin_order_form has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def next_admin_order_form()
     # if cart is empty
    if !session_admin_cart.customer_id
      return admin_shopping_users_url
    elsif !session_admin_cart.shopping_cart_items
      Severity: Minor
      Found in app/controllers/admin/shopping/checkout/base_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def create_order
    @session_admin_order = checkout_user.orders.create(:number       => Time.now.to_i,
                                                :ip_address   => request.env['REMOTE_ADDR'],
                                                :bill_address => checkout_user.billing_address  )
    add_new_cart_items(session_cart.shopping_cart_items)
      Severity: Minor
      Found in app/controllers/admin/shopping/checkout/base_controller.rb and 1 other location - About 20 mins to fix
      app/controllers/shopping/base_controller.rb on lines 64..69

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status