Sign upLogin

drhenner/ror_ecommerce

View on GitHub
Star
app/models/product.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class Product has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

class Product < ApplicationRecord
  extend FriendlyId
  friendly_id :permalink, use: :finders
  include Presentation::ProductPresenter
  include ProductFilters
Severity: Minor
Found in app/models/product.rb - About 3 hrs to fix

    Method ensure_available has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def ensure_available
      if active? && deleted_at_changed?
        self.errors.add(:base, 'There must be active variants.')  if active_variants.blank?
        self.errors.add(:base, 'Variants must have inventory.')   unless active_variants.any?{|v| v.is_available? }
        self.deleted_at = deleted_at_was if active_variants.blank? || !active_variants.any?{|v| v.is_available? }
    Severity: Minor
    Found in app/models/product.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status