Sign upLogin

drhenner/ror_ecommerce

View on GitHub
Star

Showing 346 of 346 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            if (Foundation.rtl) {
              leftOffset = this.settings.$target.offset().width - this.settings.$next_tip.width() + leftOffset;
            }
Severity: Major
Found in app/assets/javascripts/foundation/foundation.joyride.js and 1 other location - About 1 hr to fix
app/assets/javascripts/foundation/foundation.joyride.js on lines 453..455

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      target = $(evt.target).hasClass("active-result") ? $(evt.target) : $(evt.target).parents(".active-result").first();
Severity: Major
Found in app/assets/javascripts/chosen/chosen.jquery.js and 1 other location - About 1 hr to fix
app/assets/javascripts/chosen/chosen.jquery.js on lines 567..567

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method update has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def update
    @order = session_admin_order
    @order.ip_address = request.remote_ip

    @credit_card ||= ActiveMerchant::Billing::CreditCard.new(cc_params)
Severity: Minor
Found in app/controllers/admin/shopping/checkout/orders_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function result_select has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    Chosen.prototype.result_select = function(evt) {
      var high, high_id, item, position;
      if (this.result_highlight) {
        high = this.result_highlight;
        high_id = high.attr("id");
Severity: Minor
Found in app/assets/javascripts/chosen/chosen.jquery.js - About 1 hr to fix

    Function css has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        css : function (dropdown, target) {
      var offset_parent = dropdown.offsetParent();
      // if (offset_parent.length > 0 && /body/i.test(dropdown.offsetParent()[0].nodeName)) {
        var position = target.offset();
        position.top -= offset_parent.offset().top;
    Severity: Minor
    Found in app/assets/javascripts/foundation/foundation.dropdown.js - About 1 hr to fix

      Function events has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          events: function() {
      var self = this;

      //combine titles selector from settings for click event binding
      var click_title_selectors = [],
      Severity: Minor
      Found in app/assets/javascripts/foundation/foundation.section.js - About 1 hr to fix

        Function doSubmit has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                function doSubmit() {
            // make sure form attrs are set
            var t = $form.attr('target'), a = $form.attr('action');

            // update form attrs in IE friendly way
        Severity: Minor
        Found in app/assets/javascripts/jqwizard/jquery.form.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              reload : function () {
      var $self = $(this);
      return ($self.data('tooltips')) ? $self.tooltips('destroy').tooltips('init') : $self.tooltips('init');
    },
          Severity: Major
          Found in app/assets/javascripts/admin/jquery.tooltips.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/foundation/foundation.tooltips.js on lines 194..198

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (v && v.constructor == Array) {
            for (var i=0,max=v.length; i < max; i++)
                a.push({name: n, value: v[i]});
        }
        else if (v !== null && typeof v != 'undefined')
          Severity: Major
          Found in app/assets/javascripts/jqwizard/jquery.form.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/jqwizard/jquery.form.js on lines 459..464

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (v && v.constructor == Array) {
            for(var j=0, jmax=v.length; j < jmax; j++)
                a.push({name: n, value: v[j]});
        }
        else if (v !== null && typeof v != 'undefined')
          Severity: Major
          Found in app/assets/javascripts/jqwizard/jquery.form.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/jqwizard/jquery.form.js on lines 497..502

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              reload : function () {
      var $self = $(this);

      return ($self.data('fndtn-tooltips')) ? $self.foundationTooltips('destroy').foundationTooltips('init') : $self.foundationTooltips('init');
    },
          Severity: Major
          Found in app/assets/javascripts/foundation/foundation.tooltips.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/admin/jquery.tooltips.js on lines 93..96

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function preview has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                function preview() {
        if (!previewWindow || previewWindow.closed) {
          if (options.previewInWindow) {
            previewWindow = window.open('', 'preview', options.previewInWindow);
            $(window).unload(function() {
          Severity: Minor
          Found in app/assets/javascripts/markitup/jquery.markitup.js - About 1 hr to fix

            Function init has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    init: function() {
            this.labelContainer = $(this.settings.errorLabelContainer);
            this.errorContext = this.labelContainer.length && this.labelContainer || $(this.currentForm);
            this.containers = $(this.settings.errorContainer).add( this.settings.errorLabelContainer );
            this.submitted = {};
            Severity: Minor
            Found in app/assets/javascripts/jqwizard/jquery.validate.js - About 1 hr to fix

              Function pos_phone has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  pos_phone : function (init) {
      var tip_height = this.outerHeight(this.settings.$next_tip),
          tip_offset = this.settings.$next_tip.offset(),
          target_height = this.outerHeight(this.settings.$target),
          $nub = $('.joyride-nub', this.settings.$next_tip),
              Severity: Minor
              Found in app/assets/javascripts/foundation/foundation.joyride.js - About 1 hr to fix

                Function openAnimation has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      function openAnimation() {
        if (!locked) {
          lockModal();
          closeOpenModals(modal);
          modal.addClass("open");
                Severity: Minor
                Found in app/assets/javascripts/admin/jquery.reveal.js - About 1 hr to fix

                  Function refresh_custom_select has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      refresh_custom_select: function ($select, force_refresh) {
      var self = this;
      var maxWidth = 0,
          $customSelect = $select.next(),
          $options = $select.find('option'),
                  Severity: Minor
                  Found in app/assets/javascripts/foundation/foundation.forms.js - About 1 hr to fix

                    Function ajaxForm has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    $.fn.ajaxForm = function(options) {
    return this.ajaxFormUnbind().bind('submit.form-plugin', function(e) {
        e.preventDefault();
        $(this).ajaxSubmit(options);
    }).bind('click.form-plugin', function(e) {
                    Severity: Minor
                    Found in app/assets/javascripts/jqwizard/jquery.form.js - About 1 hr to fix

                      Function ajaxJSONP has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        $.ajaxJSONP = function(options){
    if (!('type' in options)) return $.ajax(options)

    var callbackName = 'jsonp' + (++jsonpID),
      script = document.createElement('script'),
                      Severity: Minor
                      Found in app/assets/javascripts/zepto.js - About 1 hr to fix

                        Function initialize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            initialize      : function() {
      jQuery('#submit_add_to_cart').click( function() {
          if (jQuery('#cart_item_variant_id').val() == '' ) { // Select to see if variant is selected in hidden field
            alert('Please click on a specific item to add.');
          } else
                        Severity: Minor
                        Found in app/assets/javascripts/shopping/cart.js - About 1 hr to fix

                          Function magicMarkups has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                function magicMarkups(string) {
        if (string) {
          string = string.toString();
          string = string.replace(/\(\!\(([\s\S]*?)\)\!\)/g,
            function(x, a) {
                          Severity: Minor
                          Found in app/assets/javascripts/markitup/jquery.markitup.js - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language