drnic/inception-server

View on GitHub

Showing 9 of 9 total issues

Class InceptionServer has 35 methods (exceeds 20 allowed). Consider refactoring.
Open

  class InceptionServer

    DEFAULT_SERVER_NAME = "inception"
    DEFAULT_DISK_SIZE = 16
    DEFAULT_SECURITY_GROUPS = ["ssh"]
Severity: Minor
Found in lib/inception/inception_server.rb - About 4 hrs to fix

    Method extract_port_definition has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def extract_port_definition(port_defn)
        protocol = "tcp"
        ip_range = "0.0.0.0/0"
        if port_defn.is_a? Integer
          port_range = (port_defn..port_defn)
    Severity: Minor
    Found in lib/inception/providers/clients/fog_provider_client.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create_security_group has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def create_security_group(security_group_name, description, ports)
        security_groups = fog_compute.security_groups
        unless sg = security_groups.find { |s| s.name == security_group_name }
          sg = fog_compute.security_groups.create(name: security_group_name, description: description)
          puts "Created security group #{security_group_name}"
    Severity: Minor
    Found in lib/inception/providers/clients/fog_provider_client.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ensure_required_security_groups has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def ensure_required_security_groups
          if @attributes["security_groups"] && @attributes["security_groups"].is_a?(Array)
            unless @attributes["security_groups"].include?("ssh")
              @attributes["security_groups"] = ["ssh", *@attributes["security_groups"]]
            end
    Severity: Minor
    Found in lib/inception/inception_server.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method bootstrap has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def bootstrap(new_attributes)
        public_ip_address = new_attributes.delete(:public_ip_address)
    
        server = fog_compute.servers.new(new_attributes)
    
    
    Severity: Minor
    Found in lib/inception/providers/clients/fog_provider_client.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(attributes, cli_options)
          @attributes = attributes.is_a?(Hash) ? ReadWriteSettings.new(attributes) : attributes
          raise "@attributes must be ReadWriteSettings (or Hash)" unless @attributes.is_a?(ReadWriteSettings)
          raise "@cli_options must be Hash" unless cli_options.is_a?(Hash)
          apply_cli_options(cli_options)
    Severity: Minor
    Found in lib/inception/next_deploy_actions.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method prepare_deploy_settings has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def prepare_deploy_settings
            header "Preparing deployment settings"
            update_git_config
            provision_or_reuse_public_ip_address_for_inception unless settings.exists?("inception.provisioned.ip_address")
            recreate_key_pair_for_inception unless settings.exists?("inception.key_pair.private_key")
    Severity: Minor
    Found in lib/inception/cli.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    execute "git config user.name" do
      command "git config --global --replace-all user.name '#{node.git.name}'"
      user node.user.username
      group node.user.username
      action :run
    Severity: Minor
    Found in cookbooks/bosh_inception/recipes/setup_git.rb and 1 other location - About 25 mins to fix
    cookbooks/bosh_inception/recipes/setup_git.rb on lines 20..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    execute "git config user.email" do
      command "git config --global --replace-all user.email '#{node.git.email}'"
      user node.user.username
      group node.user.username
      action :run
    Severity: Minor
    Found in cookbooks/bosh_inception/recipes/setup_git.rb and 1 other location - About 25 mins to fix
    cookbooks/bosh_inception/recipes/setup_git.rb on lines 12..17

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language