Sign upLogin

dropwizard/dropwizard

View on GitHub
Star
dropwizard-client/src/main/java/io/dropwizard/client/HttpClientBuilder.java

Summary

Maintainability
C
1 day
Test Coverage

File HttpClientBuilder.java has 307 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package io.dropwizard.client;

import com.codahale.metrics.MetricRegistry;
import com.codahale.metrics.httpclient.HttpClientMetricNameStrategies;
import com.codahale.metrics.httpclient.HttpClientMetricNameStrategy;
Severity: Minor
Found in dropwizard-client/src/main/java/io/dropwizard/client/HttpClientBuilder.java - About 3 hrs to fix

    Method createClient has 80 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected ConfiguredCloseableHttpClient createClient(
            final org.apache.http.impl.client.HttpClientBuilder builder,
            final InstrumentedHttpClientConnectionManager manager,
            final String name) {
        final String cookiePolicy = configuration.isCookiesEnabled() ? CookieSpecs.DEFAULT : CookieSpecs.IGNORE_COOKIES;
    Severity: Major
    Found in dropwizard-client/src/main/java/io/dropwizard/client/HttpClientBuilder.java - About 3 hrs to fix

      HttpClientBuilder has 27 methods (exceeds 20 allowed). Consider refactoring.
      Open

      public class HttpClientBuilder {
    @SuppressWarnings("UnnecessaryLambda")
    private static final HttpRequestRetryHandler NO_RETRIES = (exception, executionCount, context) -> false;

    private final MetricRegistry metricRegistry;
      Severity: Minor
      Found in dropwizard-client/src/main/java/io/dropwizard/client/HttpClientBuilder.java - About 3 hrs to fix

        Method createClient has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

            protected ConfiguredCloseableHttpClient createClient(
            final org.apache.http.impl.client.HttpClientBuilder builder,
            final InstrumentedHttpClientConnectionManager manager,
            final String name) {
        final String cookiePolicy = configuration.isCookiesEnabled() ? CookieSpecs.DEFAULT : CookieSpecs.IGNORE_COOKIES;
        Severity: Minor
        Found in dropwizard-client/src/main/java/io/dropwizard/client/HttpClientBuilder.java - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status