dropwizard/dropwizard

View on GitHub
dropwizard-core/src/main/java/io/dropwizard/server/AbstractServerFactory.java

Summary

Maintainability
D
2 days
Test Coverage

AbstractServerFactory has 57 methods (exceeds 20 allowed). Consider refactoring.
Open

public abstract class AbstractServerFactory implements ServerFactory {
    private static final Logger LOGGER = LoggerFactory.getLogger(ServerFactory.class);

    @Valid
    @Nullable

    File AbstractServerFactory.java has 444 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package io.dropwizard.server;
    
    import com.codahale.metrics.MetricRegistry;
    import com.codahale.metrics.health.HealthCheckRegistry;
    import com.codahale.metrics.jetty9.InstrumentedHandler;

      Method buildSetUIDListener has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          protected SetUIDListener buildSetUIDListener() {
              final SetUIDListener listener = new SetUIDListener();
      
              if (startsAsRoot != null) {
                  listener.setStartServerAsPrivileged(startsAsRoot);

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method buildSetUIDListener has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected SetUIDListener buildSetUIDListener() {
              final SetUIDListener listener = new SetUIDListener();
      
              if (startsAsRoot != null) {
                  listener.setStartServerAsPrivileged(startsAsRoot);

        Method createAppServlet has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            protected Handler createAppServlet(Server server,
                                               JerseyEnvironment jersey,
                                               ObjectMapper objectMapper,
                                               Validator validator,
                                               MutableServletContextHandler handler,

          Method createAdminServlet has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              protected Handler createAdminServlet(Server server,
                                                   MutableServletContextHandler handler,
                                                   MetricRegistry metrics,
                                                   HealthCheckRegistry healthChecks,
                                                   AdminEnvironment admin) {

            There are no issues that match your filters.

            Category
            Status