Sign upLogin

dropwizard/dropwizard

View on GitHub
Star
dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java

Summary

Maintainability
D
1 day
Test Coverage

File HealthCheckManagerTest.java has 348 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package io.dropwizard.health;

import com.codahale.metrics.Counter;
import com.codahale.metrics.MetricRegistry;
import com.codahale.metrics.health.HealthCheck;
Severity: Minor
Found in dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java - About 4 hrs to fix

    Method shouldRecordNumberOfHealthyAndUnhealthyHealthChecks has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Test
    void shouldRecordNumberOfHealthyAndUnhealthyHealthChecks() {
        // given
        final Schedule schedule = new Schedule();
        final List<HealthCheckConfiguration> configs = new ArrayList<>();
    Severity: Major
    Found in dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java - About 2 hrs to fix

      Method shouldNotChangeServerStateWhenNonCriticalHealthCheckRecovers has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @Test
    void shouldNotChangeServerStateWhenNonCriticalHealthCheckRecovers() {
        final List<HealthCheckConfiguration> configs = new ArrayList<>();
        final HealthCheckConfiguration nonCriticalConfig = new HealthCheckConfiguration();
        nonCriticalConfig.setName(NAME);
      Severity: Minor
      Found in dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java - About 1 hr to fix

        Method shouldContinueScheduledCheckingWhileDelayingShutdown has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @Test
    @DisabledOnOs(OS.WINDOWS)
    void shouldContinueScheduledCheckingWhileDelayingShutdown() throws Exception {
        // given
        final int checkIntervalMillis = 10;
        Severity: Minor
        Found in dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  final ScheduledHealthCheck check1 = new ScheduledHealthCheck(NAME, READY, nonCriticalConfig.isCritical(), check,
            schedule, new State(NAME, schedule.getFailureAttempts(), schedule.getSuccessAttempts(), true, manager),
            metrics.counter(NAME + ".healthy"), metrics.counter(NAME + ".unhealthy"));
          Severity: Minor
          Found in dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java and 1 other location - About 45 mins to fix
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 331..333

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  final ScheduledHealthCheck check2 = new ScheduledHealthCheck(NAME_2, READY, criticalConfig.isCritical(), check,
            schedule, new State(NAME, schedule.getFailureAttempts(), schedule.getSuccessAttempts(), true, manager),
            metrics.counter(NAME_2 + ".healthy"), metrics.counter(NAME_2 + ".unhealthy"));
          Severity: Minor
          Found in dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java and 1 other location - About 45 mins to fix
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 328..330

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                      .satisfies(values -> assertThat(values).element(4)
                .satisfies(value -> assertThat(value.getName()).isEqualTo(NAME))
                .satisfies(value -> assertThat(value.isCritical()).isFalse()));
          Severity: Major
          Found in dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java and 4 other locations - About 30 mins to fix
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 272..274
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 275..277
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 278..280
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 281..283

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                      .satisfies(values -> assertThat(values).element(0)
                .satisfies(value -> assertThat(value.getName()).isEqualTo(NAME))
                .satisfies(value -> assertThat(value.isCritical()).isFalse()))
          Severity: Major
          Found in dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java and 4 other locations - About 30 mins to fix
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 275..277
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 278..280
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 281..283
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 284..286

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                      .satisfies(values -> assertThat(values).element(3)
                .satisfies(value -> assertThat(value.getName()).isEqualTo(NAME_2))
                .satisfies(value -> assertThat(value.isCritical()).isTrue()))
          Severity: Major
          Found in dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java and 4 other locations - About 30 mins to fix
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 272..274
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 275..277
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 278..280
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 284..286

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                      .satisfies(values -> assertThat(values).element(2)
                .satisfies(value -> assertThat(value.getName()).isEqualTo(NAME))
                .satisfies(value -> assertThat(value.isCritical()).isFalse()))
          Severity: Major
          Found in dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java and 4 other locations - About 30 mins to fix
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 272..274
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 275..277
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 281..283
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 284..286

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                      .satisfies(values -> assertThat(values).element(1)
                .satisfies(value -> assertThat(value.getName()).isEqualTo(NAME_2))
                .satisfies(value -> assertThat(value.isCritical()).isTrue()))
          Severity: Major
          Found in dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java and 4 other locations - About 30 mins to fix
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 272..274
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 278..280
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 281..283
          dropwizard-health/src/test/java/io/dropwizard/health/HealthCheckManagerTest.java on lines 284..286

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status