dropwizard/dropwizard

Method testBuildConnector has 57 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    @Test
    void testBuildConnector() throws Exception {
        HttpConnectorFactory http = spy(new HttpConnectorFactory());
        http.setBindHost("127.0.0.1");
        http.setAcceptorThreads(Optional.of(1));

Method testParseFullConfiguration has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    @Test
    void testParseFullConfiguration() throws Exception {
        HttpConnectorFactory http =
                new YamlConfigurationFactory<>(HttpConnectorFactory.class, validator, objectMapper, "dw")
                        .build(new ResourceConfigurationSourceProvider(), "yaml/http-connector.yml");

Method testParseMinimalConfiguration has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    @Test
    void testParseMinimalConfiguration() throws Exception {
        HttpConnectorFactory http =
                new YamlConfigurationFactory<>(HttpConnectorFactory.class, validator, objectMapper, "dw")
                        .build(new ResourceConfigurationSourceProvider(), "yaml/http-connector-minimal.yml");

Do not hard code the IP address

Open

        assertThat(http.getBindHost()).isEqualTo("127.0.0.1");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

public class Foo {
 private String ip = '127.0.0.1'; // not recommended
}

Do not hard code the IP address

Open

        http.setBindHost("127.0.0.1");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

public class Foo {
 private String ip = '127.0.0.1'; // not recommended
}

Do not hard code the IP address

Open

        http.setBindHost("127.0.0.1");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

public class Foo {
 private String ip = '127.0.0.1'; // not recommended
}

Do not hard code the IP address

Open

                assertThat(connector.getHost()).isEqualTo("127.0.0.1");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

public class Foo {
 private String ip = '127.0.0.1'; // not recommended
}

Do not hard code the IP address

Open

        http.setBindHost("127.0.0.1");

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

public class Foo {
 private String ip = '127.0.0.1'; // not recommended
}