Sign upLogin

dropwizard/dropwizard

View on GitHub
Star
dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java

Summary

Maintainability
D
1 day
Test Coverage

File TaskServletTest.java has 304 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package io.dropwizard.servlets.tasks;

import com.codahale.metrics.MetricRegistry;
import com.codahale.metrics.annotation.ExceptionMetered;
import com.codahale.metrics.annotation.Metered;
Severity: Minor
Found in dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java - About 3 hrs to fix

    TaskServletTest has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class TaskServletTest {
    private final Task gc = mock(Task.class);
    private final PostBodyTask printJSON = mock(PostBodyTask.class);

    private final MetricRegistry metricRegistry = new MetricRegistry();
    Severity: Minor
    Found in dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @Test
    void testDoNotPrintStackTrackWhenDisabled() throws Exception {
        final TaskConfiguration taskConfiguration = new TaskConfiguration();
        taskConfiguration.setPrintStackTraceOnError(false);
        final TaskServlet servlet = new TaskServlet(metricRegistry, taskConfiguration);
      Severity: Major
      Found in dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java and 1 other location - About 2 hrs to fix
      dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java on lines 312..335

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 179.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @Test
    void testPrintStackTrackWhenEnabled() throws Exception {
        final TaskConfiguration taskConfiguration = new TaskConfiguration();
        taskConfiguration.setPrintStackTraceOnError(true);
        final TaskServlet servlet = new TaskServlet(metricRegistry, taskConfiguration);
      Severity: Major
      Found in dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java and 1 other location - About 2 hrs to fix
      dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java on lines 337..360

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 179.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          @Test
    void returnsA404WhenNotFound() throws Exception {
        when(request.getMethod()).thenReturn("POST");
        when(request.getPathInfo()).thenReturn("/test");
      Severity: Minor
      Found in dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java and 2 other locations - About 35 mins to fix
      dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java on lines 208..215
      dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java on lines 217..224

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          @Test
    void returnsA405WhenGettingTaskByName() throws Exception {
        when(request.getMethod()).thenReturn("GET");
        when(request.getPathInfo()).thenReturn("/gc");
        servlet.service(request, response);
      Severity: Minor
      Found in dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java and 2 other locations - About 35 mins to fix
      dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java on lines 51..59
      dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java on lines 208..215

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          @Test
    void returnsA404WhenGettingUnknownTask() throws Exception {
        when(request.getMethod()).thenReturn("GET");
        when(request.getPathInfo()).thenReturn("/absent");
        servlet.service(request, response);
      Severity: Minor
      Found in dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java and 2 other locations - About 35 mins to fix
      dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java on lines 51..59
      dropwizard-servlets/src/test/java/io/dropwizard/servlets/tasks/TaskServletTest.java on lines 217..224

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status