Sign upLogin

dropwizard/dropwizard

View on GitHub
Star
dropwizard-util/src/main/java/io/dropwizard/util/DataSize.java

Summary

Maintainability
B
5 hrs
Test Coverage

DataSize has 32 methods (exceeds 20 allowed). Consider refactoring.
Open

public class DataSize implements Comparable<DataSize>, Serializable {
    private static final long serialVersionUID = 8517642678733072800L;

    private static final Pattern SIZE_PATTERN = Pattern.compile("(\\d+)\\s*(\\S*)");
    private static final SortedMap<String, DataSizeUnit> SUFFIXES;
Severity: Minor
Found in dropwizard-util/src/main/java/io/dropwizard/util/DataSize.java - About 4 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        @Override
    public boolean equals(Object obj) {
        if (this == obj) {
            return true;
        }
    Severity: Major
    Found in dropwizard-util/src/main/java/io/dropwizard/util/DataSize.java and 1 other location - About 1 hr to fix
    dropwizard-util/src/main/java/io/dropwizard/util/Duration.java on lines 140..151

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        @Override
    public int compareTo(DataSize other) {
        if (unit == other.unit) {
            return Long.compare(count, other.count);
        }
    Severity: Minor
    Found in dropwizard-util/src/main/java/io/dropwizard/util/DataSize.java and 2 other locations - About 30 mins to fix
    dropwizard-util/src/main/java/io/dropwizard/util/Duration.java on lines 168..175
    dropwizard-util/src/main/java/io/dropwizard/util/Size.java on lines 153..160

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status