dsd-meetme/frontend

View on GitHub

Showing 132 of 132 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                                userResources.userScheduleTimeslots.save({calendarId: c.id, timeslotId: ''},
                                    jQuery.param(newEvents[i])).$promise.then(function () {
                                        if (index === newEvents.length - 1 && !alsoEditEvents) {
                                            c.confirmPopup.hide();
                                            $location.path('/user');
Severity: Minor
Found in app/components/user/composeSchedule/cschedController.js and 1 other location - About 45 mins to fix
app/components/user/composeSchedule/cschedController.js on lines 156..169

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function controller has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    var controller = function (userResources, plannerResources, mixedContentToArray, $scope, $location, $routeParams) {
Severity: Minor
Found in app/components/user/meeting/nmController.js - About 45 mins to fix

    Function controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        var controller = function ($routeParams, $location, mixedContentToArray, orgResources, arrayToUrlParams) {
    Severity: Minor
    Found in app/components/organization/group/groupController.js - About 35 mins to fix

      Function controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          var controller = function ($scope, $location, dataPublisher, mixedContentToArray, configService) {
      Severity: Minor
      Found in app/components/organization/registration/regController.js - About 35 mins to fix

        Function saveMeetingTimeslots has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                var saveMeetingTimeslots = function (meetingId, events, redirect, showPopupCondition, isUpdate) {
        Severity: Minor
        Found in app/components/user/meeting/nmController.js - About 35 mins to fix

          Function controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              var controller = function ($scope, $location, dataPublisher, mixedContentToArray, configService) {
          Severity: Minor
          Found in app/components/user/signIn/usiController.js - About 35 mins to fix

            Function controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                var controller = function ($scope, $location, dataPublisher, mixedContentToArray, configService) {
            Severity: Minor
            Found in app/components/organization/signIn/osiController.js - About 35 mins to fix

              Function controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  var controller = function (userResources, mixedContentToArray, $routeParams, $scope, $location) {
              Severity: Minor
              Found in app/components/user/composeSchedule/cschedController.js - About 35 mins to fix

                Function controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    var controller = function ($scope, $routeParams, dataPublisher, mixedContentToArray, configService) {
                Severity: Minor
                Found in app/components/user/recovery/urstController.js - About 35 mins to fix

                  Function controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      var controller = function ($scope, $routeParams, $location, mixedContentToArray, orgResources) {
                  Severity: Minor
                  Found in app/components/organization/user/userController.js - About 35 mins to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    userResources.userSchedule.remove({calendarId: c.editSchedule.data.id})
                                        .$promise.then(function () {
                                            getSchedules();
                                            c.confirmPopup.hide();
                                        }, function(){
                    Severity: Minor
                    Found in app/components/user/dashboard/udashController.js and 1 other location - About 35 mins to fix
                    app/components/user/dashboard/udashController.js on lines 328..334

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                userResources.userSchedule.remove({calendarId: id})
                                    .$promise.then(function () {
                                        getSchedules();
                                        c.confirmPopup.hide();
                                    }, function(){
                    Severity: Minor
                    Found in app/components/user/dashboard/udashController.js and 1 other location - About 35 mins to fix
                    app/components/user/dashboard/udashController.js on lines 402..408

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language