dsi-icl/optimise

View on GitHub
packages/optimise-ui/src/components/admin/sync.jsx

Summary

Maintainability
B
6 hrs
Test Coverage

Function _handleSubmit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    _handleSubmit() {
        try {
            if (this.syncAddress.current.value !== '')
                new URL(this.syncAddress.current.value);
        } catch (e) {
Severity: Minor
Found in packages/optimise-ui/src/components/admin/sync.jsx - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

                {this.state.error ? <><div className={style.error}>{this.state.error}</div><br /></> : null}
Severity: Major
Found in packages/optimise-ui/src/components/admin/sync.jsx and 18 other locations - About 1 hr to fix
packages/optimise-ui/src/components/createMedicalElements/createCE.jsx on lines 153..153
packages/optimise-ui/src/components/createMedicalElements/createTest.jsx on lines 124..124
packages/optimise-ui/src/components/createMedicalElements/createTreatment.jsx on lines 203..203
packages/optimise-ui/src/components/createPatient/createPatient.jsx on lines 252..252
packages/optimise-ui/src/components/editMedicalElements/createConmitantMeds.jsx on lines 245..245
packages/optimise-ui/src/components/editMedicalElements/createConmitantMeds.jsx on lines 376..376
packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 217..217
packages/optimise-ui/src/components/editMedicalElements/editComorbidity.jsx on lines 108..108
packages/optimise-ui/src/components/editMedicalElements/editComorbidity.jsx on lines 214..214
packages/optimise-ui/src/components/editMedicalElements/editMedication.jsx on lines 274..274
packages/optimise-ui/src/components/editMedicalElements/editPregnancy.jsx on lines 167..167
packages/optimise-ui/src/components/editMedicalElements/editPregnancy.jsx on lines 339..339
packages/optimise-ui/src/components/editMedicalElements/editTest.jsx on lines 203..203
packages/optimise-ui/src/components/medicalData/treatmentInterruptions.jsx on lines 176..176
packages/optimise-ui/src/components/medicalData/treatmentInterruptions.jsx on lines 354..354
packages/optimise-ui/src/components/patientProfile/patientProfile.jsx on lines 281..281
packages/optimise-ui/src/components/pregnancyForms/pregImage.jsx on lines 269..269
packages/optimise-ui/src/components/pregnancyForms/pregnancyEntry.jsx on lines 865..865

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (this.syncAddress.current.value !== '' && this.syncKey.current.value === '') {
            this.setState({ error: 'Missing a Validation Key' });
            return;
        }
Severity: Major
Found in packages/optimise-ui/src/components/admin/sync.jsx and 1 other location - About 1 hr to fix
packages/optimise-ui/src/components/admin/sync.jsx on lines 53..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (this.syncAddress.current.value === '' && this.syncKey.current.value !== '') {
            this.setState({ error: 'Missing Remote Host information' });
            return;
        }
Severity: Major
Found in packages/optimise-ui/src/components/admin/sync.jsx and 1 other location - About 1 hr to fix
packages/optimise-ui/src/components/admin/sync.jsx on lines 57..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                <label htmlFor='key'>Validation Key:</label><br /> <input name='key' type='text' ref={this.syncKey} defaultValue={key} autoComplete='off' autoCorrect='off' autoCapitalize='off' spellCheck='false' /><br /><br />
Severity: Major
Found in packages/optimise-ui/src/components/admin/sync.jsx and 1 other location - About 1 hr to fix
packages/optimise-ui/src/components/admin/sync.jsx on lines 87..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                <label htmlFor='host'>Remote Host:</label><br /> <input name='host' type='text' ref={this.syncAddress} defaultValue={host} autoComplete='off' autoCorrect='off' autoCapitalize='off' spellCheck='false' /><br /><br />
Severity: Major
Found in packages/optimise-ui/src/components/admin/sync.jsx and 1 other location - About 1 hr to fix
packages/optimise-ui/src/components/admin/sync.jsx on lines 88..88

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status