dsi-icl/optimise

View on GitHub
packages/optimise-ui/src/components/editMedicalElements/editDemographic.jsx

Summary

Maintainability
D
2 days
Test Coverage

Function render has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const { countryOfOriginRef, dominantHandRef, ethnicityRef, genderRef } = this.state;
        const { fields, fetching } = this.props;
        if (fetching || !this.props.pii) {
            return null;

    Function _handleSubmit has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _handleSubmit(ev) {
            ev.preventDefault();
            if (this.state.lastSubmit && (new Date()).getTime() - this.state.lastSubmit < 500 ? true : false)
                return;
    

      Function _handleSubmit has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          _handleSubmit(ev) {
              ev.preventDefault();
              if (this.state.lastSubmit && (new Date()).getTime() - this.state.lastSubmit < 500 ? true : false)
                  return;
      

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      <select defaultValue={ethnicity} ref={ethnicityRef}>
                          {fields.ethnicities.map(el => <option value={el.id} key={el.id}>{el.value}</option>)}
                      </select>
      packages/optimise-ui/src/components/editMedicalElements/editDemographic.jsx on lines 185..187

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      <select defaultValue={countryOfOrigin} ref={countryOfOriginRef}>
                          {fields.countries.map(el => <option value={el.id} key={el.id}>{el.value}</option>)}
                      </select>
      packages/optimise-ui/src/components/editMedicalElements/editDemographic.jsx on lines 180..182

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      <select defaultValue={dominantHand} ref={dominantHandRef}>
                          {dominant_hands_sorted.map(el => <option value={el.id} key={el.id}>{el.value}</option>)}
                      </select>
      packages/optimise-ui/src/components/editMedicalElements/editDemographic.jsx on lines 170..172

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      <select defaultValue={gender} ref={genderRef}>
                          {genders_sorted.map(el => <option value={el.id} key={el.id}>{el.value}</option>)}
                      </select>
      packages/optimise-ui/src/components/editMedicalElements/editDemographic.jsx on lines 175..177

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              fields.genders.forEach((el) => {
                  el.value = el.value[0].toUpperCase() + el.value.slice(1).toLowerCase();
                  genders_sorted.push(el);
              });
      packages/optimise-ui/src/components/createPatient/createPatient.jsx on lines 175..178

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 68.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 12 locations. Consider refactoring.
      Open

                      <div className={style.ariane}>
                          <h2>Patient information</h2>
                          <BackButton to={`/patientProfile/${params.patientId}`} />
                      </div>
      packages/optimise-ui/src/components/createMedicalElements/createCE.jsx on lines 133..136
      packages/optimise-ui/src/components/createMedicalElements/createTest.jsx on lines 112..115
      packages/optimise-ui/src/components/createMedicalElements/createTreatment.jsx on lines 143..146
      packages/optimise-ui/src/components/createMedicalElements/createVisit.jsx on lines 94..97
      packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 70..73
      packages/optimise-ui/src/components/editMedicalElements/editCommunication.jsx on lines 41..44
      packages/optimise-ui/src/components/editMedicalElements/editCommunication.jsx on lines 78..81
      packages/optimise-ui/src/components/editMedicalElements/editEdss.jsx on lines 87..90
      packages/optimise-ui/src/components/editMedicalElements/editMedication.jsx on lines 75..78
      packages/optimise-ui/src/components/editMedicalElements/editTest.jsx on lines 69..72
      packages/optimise-ui/src/components/editMedicalElements/editVisit.jsx on lines 161..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          _handleFreeTextChange(ev) {
              const newState = { error: false };
              newState[ev.target.name] = ev.target.value;
              this.setState(newState);
          }
      packages/optimise-ui/src/components/createPatient/createPatient.jsx on lines 93..97
      packages/optimise-ui/src/components/createPatient/createPatient.jsx on lines 99..103
      packages/optimise-ui/src/components/createPatient/createPatient.jsx on lines 105..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 30 locations. Consider refactoring.
      Open

              if (this.state.lastSubmit && (new Date()).getTime() - this.state.lastSubmit < 500 ? true : false)
                  return;
      packages/optimise-ui/src/components/EDSScalculator/calculator.jsx on lines 114..115
      packages/optimise-ui/src/components/createMedicalElements/createCE.jsx on lines 88..89
      packages/optimise-ui/src/components/createMedicalElements/createTest.jsx on lines 69..70
      packages/optimise-ui/src/components/createMedicalElements/createTreatment.jsx on lines 92..93
      packages/optimise-ui/src/components/createMedicalElements/createVisit.jsx on lines 69..70
      packages/optimise-ui/src/components/createPatient/createPatient.jsx on lines 113..114
      packages/optimise-ui/src/components/editMedicalElements/createConmitantMeds.jsx on lines 187..188
      packages/optimise-ui/src/components/editMedicalElements/createConmitantMeds.jsx on lines 328..329
      packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 173..174
      packages/optimise-ui/src/components/editMedicalElements/editCommunication.jsx on lines 221..222
      packages/optimise-ui/src/components/editMedicalElements/editComorbidity.jsx on lines 39..40
      packages/optimise-ui/src/components/editMedicalElements/editComorbidity.jsx on lines 161..162
      packages/optimise-ui/src/components/editMedicalElements/editEdss.jsx on lines 48..49
      packages/optimise-ui/src/components/editMedicalElements/editMedication.jsx on lines 169..170
      packages/optimise-ui/src/components/editMedicalElements/editPregnancy.jsx on lines 76..77
      packages/optimise-ui/src/components/editMedicalElements/editPregnancy.jsx on lines 231..232
      packages/optimise-ui/src/components/editMedicalElements/editPrimaryDiagnosis.jsx on lines 52..53
      packages/optimise-ui/src/components/editMedicalElements/editPrimaryDiagnosis.jsx on lines 177..178
      packages/optimise-ui/src/components/editMedicalElements/editTest.jsx on lines 152..153
      packages/optimise-ui/src/components/editMedicalElements/editVisit.jsx on lines 99..100
      packages/optimise-ui/src/components/medicalData/ceDataPage.jsx on lines 64..65
      packages/optimise-ui/src/components/medicalData/testDataPage.jsx on lines 65..66
      packages/optimise-ui/src/components/medicalData/treatmentInterruptions.jsx on lines 76..77
      packages/optimise-ui/src/components/medicalData/treatmentInterruptions.jsx on lines 245..246
      packages/optimise-ui/src/components/medicalData/visitDataPage.jsx on lines 67..68
      packages/optimise-ui/src/components/patientProfile/patientProfile.jsx on lines 218..219
      packages/optimise-ui/src/components/pregnancyForms/pregImage.jsx on lines 59..60
      packages/optimise-ui/src/components/pregnancyForms/pregImage.jsx on lines 178..179
      packages/optimise-ui/src/components/pregnancyForms/pregnancyEntry.jsx on lines 426..427

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              this.setState({
                  lastSubmit: (new Date()).getTime()
              }, () => {
                  store.dispatch(updatePatientCall(body));
              });
      packages/optimise-ui/src/components/editMedicalElements/editCommunication.jsx on lines 226..230

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status