dsi-icl/optimise

View on GitHub
packages/optimise-ui/src/components/editMedicalElements/editTest.jsx

Summary

Maintainability
F
3 days
Test Coverage

Function render has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const { params } = this.props.match;
        const { tests, location, renderedInFrontPage } = this.props;
        const { wannaUpdate } = this.state;

    Function _handleSubmit has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _handleSubmit(ev) {
            ev.preventDefault();
            if (this.state.lastSubmit && (new Date()).getTime() - this.state.lastSubmit < 500 ? true : false)
                return;
    

      Function render has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          render() {
              const { params } = this.props.match;
              const { tests, location, renderedInFrontPage } = this.props;
              const { wannaUpdate } = this.state;
      

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _handleSubmit has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          _handleSubmit(ev) {
              ev.preventDefault();
              if (this.state.lastSubmit && (new Date()).getTime() - this.state.lastSubmit < 500 ? true : false)
                  return;
      
      Severity: Minor
      Found in packages/optimise-ui/src/components/editMedicalElements/editTest.jsx - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          _deleteFunction() {
              const { params } = this.props.match;
              const { renderedInFrontPage } = this.props;
              const body = { patientId: params.patientId, data: { testId: parseInt(params.elementId) }, to: renderedInFrontPage ? `/patientProfile/${params.patientId}/visitFrontPage/${params.visitId}/page/${params.currentPage}${this.props.location.search}` : `/patientProfile/${params.patientId}` };
              store.dispatch(deleteTestAPICall(body));
      packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 46..51
      packages/optimise-ui/src/components/editMedicalElements/editMedication.jsx on lines 52..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 166.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          constructor(props) {
              super(props);
              this.state = { wannaUpdate: false, elementId: props.match.params.elementId };
              this._handleClick = this._handleClick.bind(this);
              this._deleteFunction = this._deleteFunction.bind(this);
      packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 18..24

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 119.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

                                  {
                                      renderedInFrontPage ?
                                          <>
                                              <br/><br/><br/>
                                              <NavLink to={`/patientProfile/${params.patientId}/visitFrontPage/${params.visitId}/page/${params.currentPage}${this.props.location.search}`}><button>Back</button></NavLink>
      packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 86..94
      packages/optimise-ui/src/components/editMedicalElements/editMedication.jsx on lines 87..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 113.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                                  {wannaUpdate ? <><button onClick={this._handleWannaUpdateClick}>Cancel</button><br /><br /></> :
                                      <><button onClick={this._handleWannaUpdateClick}>Change test date</button><br /><br /></>
                                  }
      packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 78..80
      packages/optimise-ui/src/components/editMedicalElements/editVisit.jsx on lines 185..187

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  to: this.props.renderedInFrontPage ? `${this.props.location.pathname}${this.props.location.search}` : `/patientProfile/${patientId}/edit/test/${id}`,
      packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 190..190
      packages/optimise-ui/src/components/editMedicalElements/editMedication.jsx on lines 192..192

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          static getDerivedStateFromProps(props, state) {
              if (props.match.params.elementId === state.elementId)
                  return state;
              return {
                  ...state,
      packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 26..34
      packages/optimise-ui/src/components/editMedicalElements/editMedication.jsx on lines 25..33

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 12 locations. Consider refactoring.
      Open

                      <div className={_style.ariane}>
                          <h2>Edit test</h2>
                          <BackButton to={`/patientProfile/${params.patientId}`} />
                      </div>
      packages/optimise-ui/src/components/createMedicalElements/createCE.jsx on lines 133..136
      packages/optimise-ui/src/components/createMedicalElements/createTest.jsx on lines 112..115
      packages/optimise-ui/src/components/createMedicalElements/createTreatment.jsx on lines 143..146
      packages/optimise-ui/src/components/createMedicalElements/createVisit.jsx on lines 94..97
      packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 70..73
      packages/optimise-ui/src/components/editMedicalElements/editCommunication.jsx on lines 41..44
      packages/optimise-ui/src/components/editMedicalElements/editCommunication.jsx on lines 78..81
      packages/optimise-ui/src/components/editMedicalElements/editDemographic.jsx on lines 20..23
      packages/optimise-ui/src/components/editMedicalElements/editEdss.jsx on lines 87..90
      packages/optimise-ui/src/components/editMedicalElements/editMedication.jsx on lines 75..78
      packages/optimise-ui/src/components/editMedicalElements/editVisit.jsx on lines 161..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 19 locations. Consider refactoring.
      Open

                      {this.state.error ? <><div className={style.error}>{this.state.error}</div><br /></> : null}
      packages/optimise-ui/src/components/admin/sync.jsx on lines 89..89
      packages/optimise-ui/src/components/createMedicalElements/createCE.jsx on lines 153..153
      packages/optimise-ui/src/components/createMedicalElements/createTest.jsx on lines 124..124
      packages/optimise-ui/src/components/createMedicalElements/createTreatment.jsx on lines 203..203
      packages/optimise-ui/src/components/createPatient/createPatient.jsx on lines 252..252
      packages/optimise-ui/src/components/editMedicalElements/createConmitantMeds.jsx on lines 245..245
      packages/optimise-ui/src/components/editMedicalElements/createConmitantMeds.jsx on lines 376..376
      packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 217..217
      packages/optimise-ui/src/components/editMedicalElements/editComorbidity.jsx on lines 108..108
      packages/optimise-ui/src/components/editMedicalElements/editComorbidity.jsx on lines 214..214
      packages/optimise-ui/src/components/editMedicalElements/editMedication.jsx on lines 274..274
      packages/optimise-ui/src/components/editMedicalElements/editPregnancy.jsx on lines 167..167
      packages/optimise-ui/src/components/editMedicalElements/editPregnancy.jsx on lines 339..339
      packages/optimise-ui/src/components/medicalData/treatmentInterruptions.jsx on lines 176..176
      packages/optimise-ui/src/components/medicalData/treatmentInterruptions.jsx on lines 354..354
      packages/optimise-ui/src/components/patientProfile/patientProfile.jsx on lines 281..281
      packages/optimise-ui/src/components/pregnancyForms/pregImage.jsx on lines 269..269
      packages/optimise-ui/src/components/pregnancyForms/pregnancyEntry.jsx on lines 865..865

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (!this.state.startDate || !this.state.startDate.isValid()) {
                  return this.setState({
                      error: 'Please indicate the date of test'
                  });
              }
      packages/optimise-ui/src/components/createMedicalElements/createTest.jsx on lines 72..76

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 30 locations. Consider refactoring.
      Open

              if (this.state.lastSubmit && (new Date()).getTime() - this.state.lastSubmit < 500 ? true : false)
                  return;
      packages/optimise-ui/src/components/EDSScalculator/calculator.jsx on lines 114..115
      packages/optimise-ui/src/components/createMedicalElements/createCE.jsx on lines 88..89
      packages/optimise-ui/src/components/createMedicalElements/createTest.jsx on lines 69..70
      packages/optimise-ui/src/components/createMedicalElements/createTreatment.jsx on lines 92..93
      packages/optimise-ui/src/components/createMedicalElements/createVisit.jsx on lines 69..70
      packages/optimise-ui/src/components/createPatient/createPatient.jsx on lines 113..114
      packages/optimise-ui/src/components/editMedicalElements/createConmitantMeds.jsx on lines 187..188
      packages/optimise-ui/src/components/editMedicalElements/createConmitantMeds.jsx on lines 328..329
      packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 173..174
      packages/optimise-ui/src/components/editMedicalElements/editCommunication.jsx on lines 221..222
      packages/optimise-ui/src/components/editMedicalElements/editComorbidity.jsx on lines 39..40
      packages/optimise-ui/src/components/editMedicalElements/editComorbidity.jsx on lines 161..162
      packages/optimise-ui/src/components/editMedicalElements/editDemographic.jsx on lines 87..88
      packages/optimise-ui/src/components/editMedicalElements/editEdss.jsx on lines 48..49
      packages/optimise-ui/src/components/editMedicalElements/editMedication.jsx on lines 169..170
      packages/optimise-ui/src/components/editMedicalElements/editPregnancy.jsx on lines 76..77
      packages/optimise-ui/src/components/editMedicalElements/editPregnancy.jsx on lines 231..232
      packages/optimise-ui/src/components/editMedicalElements/editPrimaryDiagnosis.jsx on lines 52..53
      packages/optimise-ui/src/components/editMedicalElements/editPrimaryDiagnosis.jsx on lines 177..178
      packages/optimise-ui/src/components/editMedicalElements/editVisit.jsx on lines 99..100
      packages/optimise-ui/src/components/medicalData/ceDataPage.jsx on lines 64..65
      packages/optimise-ui/src/components/medicalData/testDataPage.jsx on lines 65..66
      packages/optimise-ui/src/components/medicalData/treatmentInterruptions.jsx on lines 76..77
      packages/optimise-ui/src/components/medicalData/treatmentInterruptions.jsx on lines 245..246
      packages/optimise-ui/src/components/medicalData/visitDataPage.jsx on lines 67..68
      packages/optimise-ui/src/components/patientProfile/patientProfile.jsx on lines 218..219
      packages/optimise-ui/src/components/pregnancyForms/pregImage.jsx on lines 59..60
      packages/optimise-ui/src/components/pregnancyForms/pregImage.jsx on lines 178..179
      packages/optimise-ui/src/components/pregnancyForms/pregnancyEntry.jsx on lines 426..427

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          _handleClick(ev) {
              ev.preventDefault();
              store.dispatch(addAlert({ alert: 'Are you sure you want to delete this test record?', handler: this._deleteFunction }));
          }
      packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 41..44
      packages/optimise-ui/src/components/editMedicalElements/editMedication.jsx on lines 40..43
      packages/optimise-ui/src/components/editMedicalElements/editVisit.jsx on lines 118..121

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          _handleWannaUpdateClick(ev) {
              ev.preventDefault();
              this.setState(oldState => ({ wannaUpdate: !oldState.wannaUpdate }));
          }
      packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 36..39
      packages/optimise-ui/src/components/editMedicalElements/editMedication.jsx on lines 35..38
      packages/optimise-ui/src/components/medicalData/utils.jsx on lines 245..248

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status