Sign upLogin

dsi-icl/optimise

View on GitHub
Star
packages/optimise-ui/src/components/medicalData/utils.jsx

Summary

Maintainability
F
2 wks
Test Coverage

Function mappingFields has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

export const mappingFields = (typeHash, references, originalValues, transformer) => {
    const curry = el => {
        const title = el[0];
        let content = el[1];
        if (content.hasOwnProperty('id')) {
Severity: Minor
Found in packages/optimise-ui/src/components/medicalData/utils.jsx - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File utils.jsx has 357 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, { Component, Fragment } from 'react';
import { Link } from 'react-router-dom';
import merge from 'deepmerge';
import moment from 'moment';
import { PickDate } from '../createMedicalElements/datepicker';
Severity: Minor
Found in packages/optimise-ui/src/components/medicalData/utils.jsx - About 4 hrs to fix

    Function render has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        render() {
        const { reference, choices, origVal } = this.props;
        if (choices.includes('LEFT'))
            return (
                <>
    Severity: Minor
    Found in packages/optimise-ui/src/components/medicalData/utils.jsx - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function render has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
        const { reference, choices, origVal } = this.props;
        if (choices.includes('LEFT'))
            return (
                <>
    Severity: Major
    Found in packages/optimise-ui/src/components/medicalData/utils.jsx - About 3 hrs to fix

      Function mappingFields has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const mappingFields = (typeHash, references, originalValues, transformer) => {
    const curry = el => {
        const title = el[0];
        let content = el[1];
        if (content.hasOwnProperty('id')) {
      Severity: Major
      Found in packages/optimise-ui/src/components/medicalData/utils.jsx - About 2 hrs to fix

        Function curry has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            const curry = el => {
        const title = el[0];
        let content = el[1];
        if (content.hasOwnProperty('id')) {
            if (transformer !== undefined)
        Severity: Major
        Found in packages/optimise-ui/src/components/medicalData/utils.jsx - About 2 hrs to fix

          Avoid too many return statements within this function.
          Open

                  return (
            <select ref={reference} defaultValue={origVal}>
                <option value='unselected'></option>
                {choices.map(el => <option key={el} value={el}>{el}</option>)}
            </select>
          Severity: Major
          Found in packages/optimise-ui/src/components/medicalData/utils.jsx - About 30 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (choices.length === 2 && choices.includes('3'))
            return (
                <>
                    <table className={style.otButton}>
                        <tbody>
            Severity: Major
            Found in packages/optimise-ui/src/components/medicalData/utils.jsx and 2 other locations - About 1 day to fix
            packages/optimise-ui/src/components/medicalData/utils.jsx on lines 177..193
            packages/optimise-ui/src/components/medicalData/utils.jsx on lines 194..210

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 325.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (choices.length === 2 && choices.includes('1'))
            return (
                <>
                    <table className={style.otButton}>
                        <tbody>
            Severity: Major
            Found in packages/optimise-ui/src/components/medicalData/utils.jsx and 2 other locations - About 1 day to fix
            packages/optimise-ui/src/components/medicalData/utils.jsx on lines 177..193
            packages/optimise-ui/src/components/medicalData/utils.jsx on lines 211..227

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 325.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (choices.length === 3 && choices.includes('NORMAL'))
            return (
                <>
                    <table className={style.leftRightButton}>
                        <tbody>
            Severity: Major
            Found in packages/optimise-ui/src/components/medicalData/utils.jsx and 2 other locations - About 1 day to fix
            packages/optimise-ui/src/components/medicalData/utils.jsx on lines 194..210
            packages/optimise-ui/src/components/medicalData/utils.jsx on lines 211..227

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 325.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                _handleNormalClick(ev) {

        ev.preventDefault();

        let nullify = false;
            Severity: Major
            Found in packages/optimise-ui/src/components/medicalData/utils.jsx and 2 other locations - About 1 day to fix
            packages/optimise-ui/src/components/medicalData/utils.jsx on lines 51..74
            packages/optimise-ui/src/components/medicalData/utils.jsx on lines 76..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 298.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                _handleOneTwoClick(ev) {

        ev.preventDefault();

        let nullify = false;
            Severity: Major
            Found in packages/optimise-ui/src/components/medicalData/utils.jsx and 2 other locations - About 1 day to fix
            packages/optimise-ui/src/components/medicalData/utils.jsx on lines 76..99
            packages/optimise-ui/src/components/medicalData/utils.jsx on lines 101..124

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 298.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                _handleThreeFourClick(ev) {

        ev.preventDefault();

        let nullify = false;
            Severity: Major
            Found in packages/optimise-ui/src/components/medicalData/utils.jsx and 2 other locations - About 1 day to fix
            packages/optimise-ui/src/components/medicalData/utils.jsx on lines 51..74
            packages/optimise-ui/src/components/medicalData/utils.jsx on lines 101..124

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 298.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                return (
                        <div key={Math.random()} className={style.dataItem}>
                            <label>{content.definition}{content.unit ? <em> in {content.unit}</em> : ''}</label>
                            <AntibodyField origVal={origVal ? origVal : null} reference={references[content.id].ref} /><br /><br />
                        </div>
            Severity: Major
            Found in packages/optimise-ui/src/components/medicalData/utils.jsx and 1 other location - About 5 hrs to fix
            packages/optimise-ui/src/components/medicalData/utils.jsx on lines 384..389

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 142.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                return (
                        <div key={Math.random()} className={style.dataItem}>
                            <label>{content.definition}{content.unit ? <em> in {content.unit}</em> : ''}</label>
                            <TextField origVal={origVal ? origVal : null} reference={references[content.id].ref} /><br /><br />
                        </div>
            Severity: Major
            Found in packages/optimise-ui/src/components/medicalData/utils.jsx and 1 other location - About 5 hrs to fix
            packages/optimise-ui/src/components/medicalData/utils.jsx on lines 377..382

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 142.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                _onClick(ev) {
        ev.preventDefault();
        this.setState(prevState => ({ checked: !prevState.checked }));
    }
            Severity: Major
            Found in packages/optimise-ui/src/components/medicalData/utils.jsx and 3 other locations - About 35 mins to fix
            packages/optimise-ui/src/components/editMedicalElements/editClinicalEvent.jsx on lines 36..39
            packages/optimise-ui/src/components/editMedicalElements/editMedication.jsx on lines 35..38
            packages/optimise-ui/src/components/editMedicalElements/editTest.jsx on lines 34..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status