Sign upLogin

dsi-icl/optimise

View on GitHub
Star
packages/optimise-ui/src/components/scaffold/syncIndicator.jsx

Summary

Maintainability
C
1 day
Test Coverage

Function _updateStatus has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _updateStatus() {

        const now = (new Date()).getTime();
        const { syncInfo: { config, status: { syncing, error, status } }, loggedIn } = this.props;
        const { lastCall, triggered } = this.state;
Severity: Major
Found in packages/optimise-ui/src/components/scaffold/syncIndicator.jsx - About 2 hrs to fix

    Function render has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        render() {
        const { syncInfo } = this.props;

        if (syncInfo.config === undefined || syncInfo.config.host === undefined || syncInfo.config.host === '')
            return null;
    Severity: Minor
    Found in packages/optimise-ui/src/components/scaffold/syncIndicator.jsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _updateStatus has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        _updateStatus() {

        const now = (new Date()).getTime();
        const { syncInfo: { config, status: { syncing, error, status } }, loggedIn } = this.props;
        const { lastCall, triggered } = this.state;
    Severity: Minor
    Found in packages/optimise-ui/src/components/scaffold/syncIndicator.jsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
        const { syncInfo } = this.props;

        if (syncInfo.config === undefined || syncInfo.config.host === undefined || syncInfo.config.host === '')
            return null;
    Severity: Minor
    Found in packages/optimise-ui/src/components/scaffold/syncIndicator.jsx - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

                  return;
      Severity: Major
      Found in packages/optimise-ui/src/components/scaffold/syncIndicator.jsx - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return (
                <span title={lastSuccess}><strong className={style.statusIcon}><Icon symbol={'cloud'}></Icon></strong> Synced with {(new URL(syncInfo.config.host)).host}</span>
            );
        Severity: Major
        Found in packages/optimise-ui/src/components/scaffold/syncIndicator.jsx - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return null;
          Severity: Major
          Found in packages/optimise-ui/src/components/scaffold/syncIndicator.jsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return;
            Severity: Major
            Found in packages/optimise-ui/src/components/scaffold/syncIndicator.jsx - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          setTimeout(() => {
                this.props.syncNow(true);
                clearInterval(this.statusUpdater);
                state.triggered = true;
                this.setState(state);
              Severity: Major
              Found in packages/optimise-ui/src/components/scaffold/syncIndicator.jsx and 1 other location - About 1 hr to fix
              packages/optimise-ui/src/components/scaffold/syncIndicator.jsx on lines 79..85

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          setTimeout(() => {
                this.props.syncNow(true);
                clearInterval(this.statusUpdater);
                state.triggered = true;
                this.setState(state);
              Severity: Major
              Found in packages/optimise-ui/src/components/scaffold/syncIndicator.jsx and 1 other location - About 1 hr to fix
              packages/optimise-ui/src/components/scaffold/syncIndicator.jsx on lines 64..70

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status