Sign upLogin

dsi-icl/optimise

View on GitHub
Star
packages/optimise-ui/src/components/treePicker/treePicker.jsx

Summary

Maintainability
B
4 hrs
Test Coverage

Function constructor has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    constructor(props) {
        super(props);
        const state = {
            currentTermName: '',
            filterText: '',
Severity: Major
Found in packages/optimise-ui/src/components/treePicker/treePicker.jsx - About 2 hrs to fix

    Function render has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
        const { formatter = (node) => node.name, hash } = this.props;
        const { currentTermName, filterTerm, filterText, opened, nodes } = this.state;
        const { nodes: filteredNodes } = filterTerm !== '' ? filterNodes(nameMatchesSearchTerm(filterTerm), nodes) : { nodes };
    Severity: Minor
    Found in packages/optimise-ui/src/components/treePicker/treePicker.jsx - About 1 hr to fix

      Function filterNodes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      const filterNodes = (filter, nodes) =>
    nodes.reduce((filtered, n) => {
        const { nodes: filteredChildren } = n.children ? filterNodes(filter, n.children) : { nodes: [] };
        return !(filter(n) || filteredChildren.length) ? filtered : {
            nodes: [
      Severity: Minor
      Found in packages/optimise-ui/src/components/treePicker/treePicker.jsx - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status