Sign upLogin

dsifford/academic-bloggers-toolkit

View on GitHub
Star
src/js/utils/file.ts

Summary

Maintainability
A
1 hr
Test Coverage

Function parseCSL has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function parseCSL(file: File): Promise<Style> {
    const content = await readFile(file);
    const xml = new DOMParser().parseFromString(content, 'application/xml');
    const error = xml.querySelector('parsererror');
    const label = xml.querySelector('info title');
Severity: Minor
Found in src/js/utils/file.ts - About 1 hr to fix

    Function parseCSL has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    export async function parseCSL(file: File): Promise<Style> {
    const content = await readFile(file);
    const xml = new DOMParser().parseFromString(content, 'application/xml');
    const error = xml.querySelector('parsererror');
    const label = xml.querySelector('info title');
    Severity: Minor
    Found in src/js/utils/file.ts - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status