Sign upLogin

dspies/ua-security-state-manager

View on GitHub
Star
app/scripts/services/stateManager.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function stateManagerProvider has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  .provider('stateManager', [function stateManagerProvider(){

    var loginStateName = 'login';
    this.setLoginStateName = function (stateName) {
      loginStateName = stateName;
Severity: Major
Found in app/scripts/services/stateManager.js - About 2 hrs to fix

    Function stateManagerFactory has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function stateManagerFactory(securityService, $state, $rootScope) {

      var loggedIn = function () {
        return securityService.isAuthenticated();
      };
    Severity: Major
    Found in app/scripts/services/stateManager.js - About 2 hrs to fix

      Function stateManagerProvider has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        .provider('stateManager', [function stateManagerProvider(){

    var loginStateName = 'login';
    this.setLoginStateName = function (stateName) {
      loginStateName = stateName;
      Severity: Minor
      Found in app/scripts/services/stateManager.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function stateChangeStartAuthorizationInterceptor has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            var stateChangeStartAuthorizationInterceptor = function(event, toState, toParams, fromState, fromParams) {
      Severity: Minor
      Found in app/scripts/services/stateManager.js - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status