dspies/ua-security-state-manager

View on GitHub

Showing 6 of 6 total issues

Function exports has 499 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (grunt) {

  // Load grunt tasks automatically
  require('load-grunt-tasks')(grunt);

Severity: Major
Found in Gruntfile.js - About 2 days to fix

    File Gruntfile.js has 502 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Generated on 2014-04-25 using generator-angular 0.8.0
    'use strict';
    
    // # Globbing
    // for performance reasons we're only matching one level down:
    Severity: Major
    Found in Gruntfile.js - About 1 day to fix

      Function stateManagerProvider has 69 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        .provider('stateManager', [function stateManagerProvider(){
      
          var loginStateName = 'login';
          this.setLoginStateName = function (stateName) {
            loginStateName = stateName;
      Severity: Major
      Found in app/scripts/services/stateManager.js - About 2 hrs to fix

        Function stateManagerFactory has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function stateManagerFactory(securityService, $state, $rootScope) {
        
              var loggedIn = function () {
                return securityService.isAuthenticated();
              };
        Severity: Major
        Found in app/scripts/services/stateManager.js - About 2 hrs to fix

          Function stateManagerProvider has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            .provider('stateManager', [function stateManagerProvider(){
          
              var loginStateName = 'login';
              this.setLoginStateName = function (stateName) {
                loginStateName = stateName;
          Severity: Minor
          Found in app/scripts/services/stateManager.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function stateChangeStartAuthorizationInterceptor has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                var stateChangeStartAuthorizationInterceptor = function(event, toState, toParams, fromState, fromParams) {
          Severity: Minor
          Found in app/scripts/services/stateManager.js - About 35 mins to fix
            Severity
            Category
            Status
            Source
            Language