Sign upLogin

dssg/catwalk

View on GitHub
Star
catwalk/individual_importance/uniform.py

Summary

Maintainability
A
1 hr
Test Coverage

Function _entity_feature_values has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def _entity_feature_values(matrix, feature_name, as_of_date=None):
    """Finds the value of the given feature for each entity in a matrix

    Args:
        matrix (pandas.DataFrame), with index either 'entity_id' or 'entity_id'/'as_of_date'
Severity: Minor
Found in catwalk/individual_importance/uniform.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function uniform_distribution has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def uniform_distribution(db_engine, model_id, as_of_date, test_matrix_store, n_ranks):
Severity: Minor
Found in catwalk/individual_importance/uniform.py - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status