Sign upLogin

dssg/triage

View on GitHub
Star
src/tests/collate_tests/test_helpers.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function test_compare_dicts has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def test_compare_dicts():
    d = Compare(
        "col", "=", {"vala": "a", "valb": "b", "valc": "c"}, [], {}, include_null=True
    ).quantities
    assert len(d) == 4
Severity: Minor
Found in src/tests/collate_tests/test_helpers.py - About 1 hr to fix

    Function test_compare_lists has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def test_compare_lists():
    d = Compare("col", "=", ["a", "b", "c"], [], {}, include_null=True).quantities
    assert len(d) == 4
    assert len(set(d.values())) == len(d)
    assert len(set(d.keys())) == len(d)
    Severity: Minor
    Found in src/tests/collate_tests/test_helpers.py - About 1 hr to fix

      Line too long (90 > 88 characters)
      Open

              "long_column_name = 'really long string value that is also like everything else'",
      Severity: Minor
      Found in src/tests/collate_tests/test_helpers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (89 > 88 characters)
      Open

              "really_long_column_name = 'really long string value that is similar to others'",
      Severity: Minor
      Found in src/tests/collate_tests/test_helpers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (93 > 88 characters)
      Open

              "really_long_column_name = 'really long string value that is quite alike to others'",
      Severity: Minor
      Found in src/tests/collate_tests/test_helpers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Line too long (97 > 88 characters)
      Open

              "really_long_column_name = 'really long string value that is also like everything else'",
      Severity: Minor
      Found in src/tests/collate_tests/test_helpers.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      There are no issues that match your filters.

      Category
      Status