Sign upLogin

dssg/triage

View on GitHub
Star
src/tests/collate_tests/test_imputation_output.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function test_imputation_output has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

def test_imputation_output(feat_list, exp_imp_cols, feat_table):
    with testing.postgresql.Postgresql() as psql:
        engine = sqlalchemy.create_engine(psql.url())

        engine.execute("create table states (entity_id int, as_of_date date)")
Severity: Minor
Found in src/tests/collate_tests/test_imputation_output.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if (
                        feat in exp_imp_cols
                        and coltype != "categorical"
                        and imp != "zero_noflag"
                    ):
Severity: Major
Found in src/tests/collate_tests/test_imputation_output.py - About 45 mins to fix

    Line too long (90 > 88 characters)
    Open

                        # for non-categoricals, should add an "imputed" column and be non-null
    Severity: Minor
    Found in src/tests/collate_tests/test_imputation_output.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Line too long (89 > 88 characters)
    Open

                        # (categoricals are expected to be handled through the null category)
    Severity: Minor
    Found in src/tests/collate_tests/test_imputation_output.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Line too long (91 > 88 characters)
    Open

                    # excute query to find columns with null values and create lists of columns
    Severity: Minor
    Found in src/tests/collate_tests/test_imputation_output.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    There are no issues that match your filters.

    Category
    Status