Showing 25 of 37 total issues
Class CLI
has 49 methods (exceeds 20 allowed). Consider refactoring. Open
class CLI < Thor
class_option :merge, type: :string, desc: "tfstate file to merge"
class_option :overwrite, type: :boolean, desc: "Overwrite existing tfstate"
class_option :tfstate, type: :boolean, desc: "Generate tfstate"
class_option :profile, type: :string, desc: "AWS credentials profile"
Method tfstate
has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring. Open
def tfstate
records.inject({}) do |resources, r|
record, zone_id = r[:record], r[:zone_id]
counter = r[:counter]
record_id = record_id_of(record, zone_id)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Class DynamoDB
has 30 methods (exceeds 20 allowed). Consider refactoring. Open
class DynamoDB
include Terraforming::Util
def self.tf(client: Aws::DynamoDB::Client.new)
self.new(client).tf
end
Method tfstate
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
def tfstate
instances.inject({}) do |resources, instance|
in_vpc = in_vpc?(instance)
block_devices = block_devices_of(instance)
Method tfstate
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
def tfstate
auto_scaling_groups.inject({}) do |resources, group|
vpc_zone_specified = vpc_zone_specified?(group)
attributes = {
Method tfstate
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
def tfstate
db_instances.inject({}) do |resources, instance|
attributes = {
"address" => instance.endpoint.address,
"allocated_storage" => instance.allocated_storage.to_s,
Method tfstate
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
def tfstate
records.inject({}) do |resources, r|
record, zone_id = r[:record], r[:zone_id]
counter = r[:counter]
record_id = record_id_of(record, zone_id)
Method tfstate
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
def tfstate
load_balancers.inject({}) do |resources, load_balancer|
load_balancer_attributes = load_balancer_attributes_of(load_balancer)
attributes = {
"availability_zones.#" => load_balancer.availability_zones.length.to_s,
Method tfstate
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
def tfstate
cache_clusters.inject({}) do |resources, cache_cluster|
attributes = {
"cache_nodes.#" => cache_cluster.cache_nodes.length.to_s,
"cluster_id" => cache_cluster.cache_cluster_id,
Method tfstate
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def tfstate
instances.inject({}) do |resources, instance|
in_vpc = in_vpc?(instance)
block_devices = block_devices_of(instance)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method tfstate
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
def tfstate
tables.inject({}) do |resources, dynamo_db_table|
attributes = {
"arn" => dynamo_db_table["table_arn"],
"id" => dynamo_db_table["table_name"],
Method tfstate
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
def tfstate
launch_configurations.inject({}) do |resources, lc|
attributes = {
"name" => lc.launch_configuration_name,
"image_id" => lc.image_id,
Method tfstate
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def tfstate
clusters.inject({}) do |resources, cluster|
attributes = {
"cluster_identifier" => cluster.cluster_identifier,
"cluster_type" => cluster.number_of_nodes == 1 ? "single-node" : "multi-node",
Method permission_attributes_of
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def permission_attributes_of(security_group, permission, type)
hashcode = permission_hashcode_of(security_group, permission)
security_groups = security_groups_in(permission, security_group).reject do |identifier|
[security_group.group_name, security_group.group_id].include?(identifier)
end
Method tfstate
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def tfstate
subscriptions.reject { |x| x["Protocol"].include?("email") }
.inject({}) do |resources, subscription|
attributes = {
"id" => subscription["SubscriptionArn"],
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method prettify_policy
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def prettify_policy(document, breakline: false, unescape: false)
json = JSON.pretty_generate(JSON.parse(unescape ? CGI.unescape(document) : document))
if breakline
json[-1] != "\n" ? json << "\n" : json
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method records
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def records
to_return = hosted_zones.map do |hosted_zone|
record_sets_of(hosted_zone).map { |record| { record: record, zone_id: zone_id_of(hosted_zone) } }
end.flatten
count = {}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method security_groups_in
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def security_groups_in(permission, security_group)
permission.user_id_group_pairs.map do |range|
# EC2-Classic, same account
if security_group.owner_id == range.user_id && !range.group_name.nil?
range.group_name
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method tfstate
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def tfstate
auto_scaling_groups.inject({}) do |resources, group|
vpc_zone_specified = vpc_zone_specified?(group)
attributes = {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method configure_aws
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def configure_aws(options)
Aws.config[:credentials] = Aws::SharedCredentials.new(profile_name: options[:profile]) if options[:profile]
Aws.config[:region] = options[:region] if options[:region]
if options[:assume]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"