dtan4/terraforming

View on GitHub

Showing 29 of 29 total issues

Class CLI has 48 methods (exceeds 20 allowed). Consider refactoring.
Open

  class CLI < Thor
    class_option :merge, type: :string, desc: "tfstate file to merge"
    class_option :overwrite, type: :boolean, desc: "Overwrite existing tfstate"
    class_option :tfstate, type: :boolean, desc: "Generate tfstate"
    class_option :profile, type: :string, desc: "AWS credentials profile"
Severity: Minor
Found in lib/terraforming/cli.rb - About 6 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      module Resource
        class IAMRolePolicy
          include Terraforming::Util
    
          def self.tf(client: Aws::IAM::Client.new)
    Severity: Major
    Found in lib/terraforming/resource/iam_role_policy.rb and 1 other location - About 4 hrs to fix
    lib/terraforming/resource/iam_user_policy.rb on lines 2..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 148.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      module Resource
        class IAMUserPolicy
          include Terraforming::Util
    
          def self.tf(client: Aws::IAM::Client.new)
    Severity: Major
    Found in lib/terraforming/resource/iam_user_policy.rb and 1 other location - About 4 hrs to fix
    lib/terraforming/resource/iam_role_policy.rb on lines 2..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 148.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method tfstate has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

          def tfstate
            records.inject({}) do |resources, r|
              record, zone_id = r[:record], r[:zone_id]
              counter = r[:counter]
              record_id = record_id_of(record, zone_id)
    Severity: Minor
    Found in lib/terraforming/resource/route53_record.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method tfstate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def tfstate
            instances.inject({}) do |resources, instance|
              in_vpc = in_vpc?(instance)
              block_devices = block_devices_of(instance)
    
    
    Severity: Minor
    Found in lib/terraforming/resource/ec2.rb - About 1 hr to fix

      Method tfstate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def tfstate
              auto_scaling_groups.inject({}) do |resources, group|
                vpc_zone_specified = vpc_zone_specified?(group)
      
                attributes = {
      Severity: Minor
      Found in lib/terraforming/resource/auto_scaling_group.rb - About 1 hr to fix

        Method tfstate has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def tfstate
                db_instances.inject({}) do |resources, instance|
                  attributes = {
                    "address" => instance.endpoint.address,
                    "allocated_storage" => instance.allocated_storage.to_s,
        Severity: Minor
        Found in lib/terraforming/resource/rds.rb - About 1 hr to fix

          Method tfstate has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def tfstate
                  records.inject({}) do |resources, r|
                    record, zone_id = r[:record], r[:zone_id]
                    counter = r[:counter]
                    record_id = record_id_of(record, zone_id)
          Severity: Minor
          Found in lib/terraforming/resource/route53_record.rb - About 1 hr to fix

            Method tfstate has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def tfstate
                    load_balancers.inject({}) do |resources, load_balancer|
                      load_balancer_attributes = load_balancer_attributes_of(load_balancer)
                      attributes = {
                        "availability_zones.#" => load_balancer.availability_zones.length.to_s,
            Severity: Minor
            Found in lib/terraforming/resource/elb.rb - About 1 hr to fix

              Method tfstate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                    def tfstate
                      instances.inject({}) do |resources, instance|
                        in_vpc = in_vpc?(instance)
                        block_devices = block_devices_of(instance)
              
              
              Severity: Minor
              Found in lib/terraforming/resource/ec2.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method tfstate has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def tfstate
                      launch_configurations.inject({}) do |resources, lc|
                        attributes = {
                          "name" => lc.launch_configuration_name,
                          "image_id" => lc.image_id,
              Severity: Minor
              Found in lib/terraforming/resource/launch_configuration.rb - About 1 hr to fix

                Method tfstate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def tfstate
                        cache_clusters.inject({}) do |resources, cache_cluster|
                          attributes = {
                            "cache_nodes.#" => cache_cluster.cache_nodes.length.to_s,
                            "cluster_id" => cache_cluster.cache_cluster_id,
                Severity: Minor
                Found in lib/terraforming/resource/elasti_cache_cluster.rb - About 1 hr to fix

                  Method tfstate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                        def tfstate
                          clusters.inject({}) do |resources, cluster|
                            attributes = {
                              "cluster_identifier"                  => cluster.cluster_identifier,
                              "cluster_type"                        => cluster.number_of_nodes == 1 ? "single-node" : "multi-node",
                  Severity: Minor
                  Found in lib/terraforming/resource/redshift.rb - About 1 hr to fix

                    Method tfstate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def tfstate
                            subscriptions.reject { |x| x["Protocol"].include?("email") }
                                         .inject({}) do |resources, subscription|
                              attributes = {
                                "id"                              => subscription["SubscriptionArn"],
                    Severity: Minor
                    Found in lib/terraforming/resource/sns_topic_subscription.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          def tfstate
                            cache_subnet_groups.inject({}) do |resources, cache_subnet_group|
                              attributes = {
                                "description" => cache_subnet_group.cache_subnet_group_description,
                                "name" => cache_subnet_group.cache_subnet_group_name,
                    Severity: Minor
                    Found in lib/terraforming/resource/elasti_cache_subnet_group.rb and 1 other location - About 40 mins to fix
                    lib/terraforming/resource/db_subnet_group.rb on lines 22..37

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 38.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          def tfstate
                            db_subnet_groups.inject({}) do |resources, subnet_group|
                              attributes = {
                                "description" => subnet_group.db_subnet_group_description,
                                "name" => subnet_group.db_subnet_group_name,
                    Severity: Minor
                    Found in lib/terraforming/resource/db_subnet_group.rb and 1 other location - About 40 mins to fix
                    lib/terraforming/resource/elasti_cache_subnet_group.rb on lines 22..37

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 38.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method prettify_policy has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def prettify_policy(document, breakline: false, unescape: false)
                          json = JSON.pretty_generate(JSON.parse(unescape ? CGI.unescape(document) : document))
                    
                          if breakline
                            json[-1] != "\n" ? json << "\n" : json
                    Severity: Minor
                    Found in lib/terraforming/util.rb - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method records has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def records
                            to_return = hosted_zones.map do |hosted_zone|
                              record_sets_of(hosted_zone).map { |record| { record: record, zone_id: zone_id_of(hosted_zone) } }
                            end.flatten
                            count = {}
                    Severity: Minor
                    Found in lib/terraforming/resource/route53_record.rb - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          def topic_arns
                            token = ""
                            arns = []
                    
                            loop do
                    Severity: Minor
                    Found in lib/terraforming/resource/sns_topic.rb and 1 other location - About 30 mins to fix
                    lib/terraforming/resource/sns_topic_subscription.rb on lines 64..75

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 32.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                          def subscription_arns
                            token = ""
                            arns = []
                    
                            loop do
                    Severity: Minor
                    Found in lib/terraforming/resource/sns_topic_subscription.rb and 1 other location - About 30 mins to fix
                    lib/terraforming/resource/sns_topic.rb on lines 56..67

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 32.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language