Sign upLogin

dtaniwaki/e2e-tester

View on GitHub
Star
app/models/browser/local.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method driver has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def driver(_credential = nil)
      browser_name = browser.to_sym
      caps = {}
      case browser_name
      when :phantomjs
Severity: Minor
Found in app/models/browser/local.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method driver has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def driver(_credential = nil)
      browser_name = browser.to_sym
      caps = {}
      case browser_name
      when :phantomjs
Severity: Minor
Found in app/models/browser/local.rb - About 1 hr to fix

    Method update_source has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.update_source
      browsers = [
        {
          browser: 'phantomjs',
          device: 'desktop'
    Severity: Minor
    Found in app/models/browser/local.rb - About 1 hr to fix

      Method update_source has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.update_source
      browsers = [
        {
          browser: 'phantomjs',
          device: 'desktop'
      Severity: Minor
      Found in app/models/browser/local.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid rescuing without specifying an error class.
      Open

                rescue
      Severity: Minor
      Found in app/models/browser/local.rb by rubocop

      This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

      Example: EnforcedStyle: implicit

      # `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

      Example: EnforcedStyle: explicit (default)

      # `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

      Avoid rescuing without specifying an error class.
      Open

            rescue
      Severity: Minor
      Found in app/models/browser/local.rb by rubocop

      This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

      Example: EnforcedStyle: implicit

      # `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

      Example: EnforcedStyle: explicit (default)

      # `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

      Avoid rescuing without specifying an error class.
      Open

            rescue
      Severity: Minor
      Found in app/models/browser/local.rb by rubocop

      This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

      Example: EnforcedStyle: implicit

      # `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

      Example: EnforcedStyle: explicit (default)

      # `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

      Avoid rescuing without specifying an error class.
      Open

            rescue
      Severity: Minor
      Found in app/models/browser/local.rb by rubocop

      This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

      Example: EnforcedStyle: implicit

      # `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

      Example: EnforcedStyle: explicit (default)

      # `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

      There are no issues that match your filters.

      Category
      Status