Sign upLogin

dtaniwaki/e2e-tester

View on GitHub
Star
app/models/test_execution_browser.rb

Summary

Maintainability
A
0 mins
Test Coverage

Specify a :dependent option.
Open

  has_many :test_step_executions, inverse_of: :test_execution_browser
Severity: Minor
Found in app/models/test_execution_browser.rb by rubocop

This cop looks for has_many or has_one associations that don't specify a :dependent option. It doesn't register an offense if :through option was specified.

Example:

# bad
class User < ActiveRecord::Base
  has_many :comments
  has_one :avatar
end

# good
class User < ActiveRecord::Base
  has_many :comments, dependent: :restrict_with_exception
  has_one :avatar, dependent: :destroy
  has_many :patients, through: :appointments
end

TODO found
Open

    # TODO: Should perform after commit
Severity: Minor
Found in app/models/test_execution_browser.rb by fixme

Avoid rescuing without specifying an error class.
Open

  rescue => e
Severity: Minor
Found in app/models/test_execution_browser.rb by rubocop

This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

Example: EnforcedStyle: implicit

# `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

Example: EnforcedStyle: explicit (default)

# `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

There are no issues that match your filters.

Category
Status