Sign upLogin

dtaniwaki/e2e-tester

View on GitHub
Star
app/models/test_step_set.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method same_test_step_set? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def same_test_step_set?(other)
    return false if other.nil?
    return false if self.class != other.class
    return false if test_steps.length != other.test_steps.length
    return false if test_steps.map { |ts| ts.becomes ts.type.constantize }.zip(other.test_steps.map { |ts| ts.becomes ts.type.constantize }).any? { |a, b| !a.same_step?(b) }
Severity: Minor
Found in app/models/test_step_set.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

    return false if title != other.title
Severity: Major
Found in app/models/test_step_set.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

        return false if description != other.description
    Severity: Major
    Found in app/models/test_step_set.rb - About 30 mins to fix

      Specify a :dependent option.
      Open

        has_many :test_step_sets, class_name: 'TestStep::StepSet', inverse_of: :shared_test_step_set
      Severity: Minor
      Found in app/models/test_step_set.rb by rubocop

      This cop looks for has_many or has_one associations that don't specify a :dependent option. It doesn't register an offense if :through option was specified.

      Example:

      # bad
class User < ActiveRecord::Base
  has_many :comments
  has_one :avatar
end

# good
class User < ActiveRecord::Base
  has_many :comments, dependent: :restrict_with_exception
  has_one :avatar, dependent: :destroy
  has_many :patients, through: :appointments
end

      Specify a :dependent option.
      Open

        has_many :inherited_test_step_sets, class_name: 'TestStepSet', foreign_key: 'base_test_step_set_id', inverse_of: :base_test_step_set
      Severity: Minor
      Found in app/models/test_step_set.rb by rubocop

      This cop looks for has_many or has_one associations that don't specify a :dependent option. It doesn't register an offense if :through option was specified.

      Example:

      # bad
class User < ActiveRecord::Base
  has_many :comments
  has_one :avatar
end

# good
class User < ActiveRecord::Base
  has_many :comments, dependent: :restrict_with_exception
  has_one :avatar, dependent: :destroy
  has_many :patients, through: :appointments
end

      There are no issues that match your filters.

      Category
      Status