Sign upLogin

duck1123/jiksnu

View on GitHub
Star

Showing 169 of 169 total issues

Non-idiomatic code found in (fn [] (next))
Open

         (.then (fn [] (next))))))
Severity: Minor
Found in specs/jiksnu/step_definitions.cljs by kibit

Consider using:

next

instead of:

(fn [] (next))

Non-idiomatic code found in (fn [ctx] (:data ctx))
Open

  :handle-ok (fn [ctx] (:data ctx))
Severity: Minor
Found in src/jiksnu/modules/web/routes/client_routes.clj by kibit

Consider using:

:data

instead of:

(fn [ctx] (:data ctx))

Non-idiomatic code found in (fn [ctx] (:data ctx))
Open

  :post! (fn [ctx] (:data ctx)))
Severity: Minor
Found in src/jiksnu/modules/web/routes/client_routes.clj by kibit

Consider using:

:data

instead of:

(fn [ctx] (:data ctx))

Non-idiomatic code found in (-> (:params (:request ctx)) (assoc :author (:_id author)))
Open

               (let [params (-> (:params (:request ctx))
Severity: Minor
Found in src/jiksnu/modules/web/routes/user_routes.clj by kibit

Consider using:

(assoc (:params (:request ctx)) :author (:_id author))

instead of:

(-> (:params (:request ctx)) (assoc :author (:_id author)))

Non-idiomatic code found in (-> (by-model "reg.username") (.sendKeys username))
Open

        (-> (by-model "reg.username")
Severity: Minor
Found in specs/jiksnu/pages/RegisterPage.cljs by kibit

Consider using:

(.sendKeys (by-model "reg.username") username)

instead of:

(-> (by-model "reg.username") (.sendKeys username))

Non-idiomatic code found in (-> (lp/set-password page "test") (.then (fn [] (next))))
Open

     (-> (lp/set-password page "test")
Severity: Minor
Found in specs/jiksnu/step_definitions.cljs by kibit

Consider using:

(.then (lp/set-password page "test") (fn [] (next)))

instead of:

(-> (lp/set-password page "test") (.then (fn [] (next))))

Non-idiomatic code found in (-> (login page "test" "test") (.then (fn [] (timbre/info "login finished"))))
Open

    (-> (login page "test" "test")
Severity: Minor
Found in specs/jiksnu/helpers/action_helpers.cljs by kibit

Consider using:

(.then
  (login page "test" "test")
  (fn [] (timbre/info "login finished")))

instead of:

(-> (login page "test" "test")
 (.then (fn [] (timbre/info "login finished"))))

Non-idiomatic code found in (-> (by-model "reg.password") (.sendKeys password))
Open

        (-> (by-model "reg.password")
Severity: Minor
Found in specs/jiksnu/pages/RegisterPage.cljs by kibit

Consider using:

(.sendKeys (by-model "reg.password") password)

instead of:

(-> (by-model "reg.password") (.sendKeys password))

Non-idiomatic code found in (-> (helpers.http/an-activity-exists) (.then (fn [] (next))))
Open

   (-> (helpers.http/an-activity-exists)
Severity: Minor
Found in specs/jiksnu/step_definitions.cljs by kibit

Consider using:

(.then (helpers.http/an-activity-exists) (fn [] (next)))

instead of:

(-> (helpers.http/an-activity-exists) (.then (fn [] (next))))

TODO found
Open

  ;; TODO: implement
Severity: Minor
Found in src/jiksnu/actions/favorite_actions.clj by fixme

TODO found
Open

                ;; TODO: I'm not sure these should be removed
Severity: Minor
Found in src/jiksnu/actions/album_actions.clj by fixme

FIXME found
Open

                              ;; FIXME: generate a random secret
Severity: Minor
Found in src/jiksnu/actions/access_token_actions.clj by fixme

TODO found
Open

;;       ;; TODO: better exception type
Severity: Minor
Found in src/jiksnu/actions/dialback_actions.clj by fixme

TODO found
Open

                ;; TODO: I'm not sure these should be removed
Severity: Minor
Found in src/jiksnu/actions/activity_actions.clj by fixme

TODO found
Open

;; TODO: show action with :oembed format
Severity: Minor
Found in src/jiksnu/actions/activity_actions.clj by fixme

TODO found
Open

  ;; TODO: name of site
Severity: Minor
Found in src/jiksnu/modules/as/helpers.clj by fixme

FIXME found
Open

         ;; FIXME: Return actual count
Severity: Minor
Found in src/jiksnu/modules/web/helpers.clj by fixme

TODO found
Open

    ;; TODO: list urls
Severity: Minor
Found in src/jiksnu/modules/core/sections.clj by fixme

TODO found
Open

    ;; TODO: list hashtags
Severity: Minor
Found in src/jiksnu/modules/core/sections.clj by fixme

TODO found
Open

;; TODO: This operation should be performed on local posts. Remote
Severity: Minor
Found in src/jiksnu/transforms/activity_transforms.clj by fixme
Severity
Category
Status
Source
Language