duck1123/jiksnu

View on GitHub
src/jiksnu/modules/web/routes.clj

Summary

Maintainability
Test Coverage

Non-idiomatic code found in (-> (routes (route/resources "/") (route/files "/assets" {:root "/data"}) (route/files "/vendor" {:root "node_modules"}) (GET "/templates/*" [] (var helpers/serve-template)) (-> (routes async-handler (var core/jiksnu-routes)) middleware/wrap-response-logging (wrap-trace :ui) middleware/wrap-user-binding (friend/authenticate auth-config) middleware/wrap-authorization-header middleware/wrap-authentication-handler middleware/wrap-debug-param (wrap-defaults site-options))) middleware/wrap-stacktrace)
Open

  (-> (routes
Severity: Minor
Found in src/jiksnu/modules/web/routes.clj by kibit

Consider using:

(middleware/wrap-stacktrace
  (routes
    (route/resources "/")
    (route/files "/assets" {:root "/data"})
    (route/files "/vendor" {:root "node_modules"})
    (GET "/templates/*" [] #'helpers/serve-template)
    (-> (routes async-handler #'core/jiksnu-routes)
     middleware/wrap-response-logging
     (wrap-trace :ui)
     middleware/wrap-user-binding
     (friend/authenticate auth-config)
     middleware/wrap-authorization-header
     middleware/wrap-authentication-handler
     middleware/wrap-debug-param
     (wrap-defaults site-options))))

instead of:

(-> (routes
      (route/resources "/")
      (route/files "/assets" {:root "/data"})
      (route/files "/vendor" {:root "node_modules"})
      (GET "/templates/*" [] #'helpers/serve-template)
      (-> (routes async-handler #'core/jiksnu-routes)
       middleware/wrap-response-logging
       (wrap-trace :ui)
       middleware/wrap-user-binding
       (friend/authenticate auth-config)
       middleware/wrap-authorization-header
       middleware/wrap-authentication-handler
       middleware/wrap-debug-param
       (wrap-defaults site-options)))
 middleware/wrap-stacktrace)

There are no issues that match your filters.

Category
Status