Sign upLogin

duke-libraries/ddr-models

View on GitHub
Star
lib/ddr/models/describable.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method desc_metadata_terms has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def desc_metadata_terms *args
      return Ddr::Datastreams::DescriptiveMetadataDatastream.term_names if args.empty?
      arg = args.pop
      terms = case arg.to_sym
              when :empty
Severity: Minor
Found in lib/ddr/models/describable.rb - About 1 hr to fix

    Method desc_metadata_terms has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def desc_metadata_terms *args
      return Ddr::Datastreams::DescriptiveMetadataDatastream.term_names if args.empty?
      arg = args.pop
      terms = case arg.to_sym
              when :empty
    Severity: Minor
    Found in lib/ddr/models/describable.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status