duke-libraries/ddr-models

View on GitHub
lib/ddr/models/solr_document.rb

Summary

Maintainability
B
4 hrs
Test Coverage

File solr_document.rb has 310 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'json'

module Ddr::Models
  module SolrDocument
    extend ActiveSupport::Concern
Severity: Minor
Found in lib/ddr/models/solr_document.rb - About 3 hrs to fix

    Method method_missing has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def method_missing(name, *args, &block)
          if args.empty? && !block
            begin
              field = Ddr::Index::Fields.get(name)
            rescue NameError
    Severity: Minor
    Found in lib/ddr/models/solr_document.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status