Sign upLogin

duncanmmacleod/requests-ecp

View on GitHub
Star
requests_ecp/auth.py

Summary

Maintainability
A
35 mins
Test Coverage

The input method in Python 2 will read from standard input, evaluate and run the resulting string as python source code. This is similar, though in many ways worse, then using eval. On Python 2, use raw_input instead, input is safe in Python 3.
Open

        username = input("Enter username for {0}: ".format(host))
Severity: Major
Found in requests_ecp/auth.py by bandit

Function is_gitlab_auth_redirect has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def is_gitlab_auth_redirect(response):
    """Return `True` if a response indicates a gitlab auth redirect.

    Parameters
    ----------
Severity: Minor
Found in requests_ecp/auth.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status