Sign upLogin

dundee/gdu

View on GitHub
Star

Showing 58 of 59 total issues

Method SequentialAnalyzer.processDir has 66 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (a *SequentialAnalyzer) processDir(path string) *Dir {
    var (
        file      *File
        err       error
        totalSize int64
Severity: Minor
Found in pkg/analyze/sequential.go - About 1 hr to fix

    Method UI.handleMainActions has 63 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (ui *UI) handleMainActions(key *tcell.EventKey) *tcell.EventKey {
    switch key.Rune() {
    case 'd':
        ui.handleDelete(false)
    case 'e':
    Severity: Minor
    Found in tui/keys.go - About 1 hr to fix

      Method UI.deleteSelected has 63 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (ui *UI) deleteSelected(shouldEmpty bool) {
    row, column := ui.table.GetSelection()
    selectedItem := ui.table.GetCell(row, column).GetReference().(fs.Item)

    if ui.deleteInBackground {
      Severity: Minor
      Found in tui/actions.go - About 1 hr to fix

        Method UI.formatFileRow has 61 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (ui *UI) formatFileRow(item fs.Item, maxUsage, maxSize int64, marked, ignored bool) string {
    var part int

    switch {
    case ignored:
        Severity: Minor
        Found in tui/format.go - About 1 hr to fix

          Method UI.formatFileRow has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
          Open

          func (ui *UI) formatFileRow(item fs.Item, maxUsage, maxSize int64, marked, ignored bool) string {
    var part int

    switch {
    case ignored:
          Severity: Minor
          Found in tui/format.go - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function processDir has 60 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func processDir(items []interface{}) (*analyze.Dir, error) {
    dir := &analyze.Dir{
        File: &analyze.File{
            Flag: ' ',
        },
          Severity: Minor
          Found in report/import.go - About 1 hr to fix

            Method UI.keyPressed has 14 return statements (exceeds 4 allowed).
            Open

            func (ui *UI) keyPressed(key *tcell.EventKey) *tcell.EventKey {
    if ui.handleCtrlZ(key) == nil {
        return nil
    }
            Severity: Major
            Found in tui/keys.go - About 1 hr to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      for _, item := range deleteItems {
            if err := deleteFun(currentDir, item); err != nil {
                msg := "Can't " + action + " " + tview.Escape(selectedItem.GetName())
                ui.app.QueueUpdateDraw(func() {
                    ui.pages.RemovePage(acting)
              Severity: Major
              Found in tui/actions.go and 2 other locations - About 1 hr to fix
              tui/background.go on lines 62..74
              tui/marked.go on lines 82..94

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 139.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          for _, item := range deleteItems {
                if err := deleteFun(currentDir, item); err != nil {
                    msg := "Can't " + action + " " + tview.Escape(one.GetName())
                    ui.app.QueueUpdateDraw(func() {
                        ui.pages.RemovePage(acting)
              Severity: Major
              Found in tui/marked.go and 2 other locations - About 1 hr to fix
              tui/actions.go on lines 221..233
              tui/background.go on lines 62..74

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 139.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  for _, toDelete := range deleteItems {
        if err := deleteFun(parentDir, toDelete); err != nil {
            msg := "Can't " + action + " " + tview.Escape(toDelete.GetName())
            ui.app.QueueUpdateDraw(func() {
                ui.pages.RemovePage(acting)
              Severity: Major
              Found in tui/background.go and 2 other locations - About 1 hr to fix
              tui/actions.go on lines 221..233
              tui/marked.go on lines 82..94

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 139.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function CreateStdoutUI has 9 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  output io.Writer,
    useColors bool,
    showProgress bool,
    showApparentSize bool,
    showRelativeSize bool,
              Severity: Major
              Found in stdout/stdout.go - About 1 hr to fix

                Function CreateUI has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    app common.TermApplication,
    screen tcell.Screen,
    output io.Writer,
    useColors bool,
    showApparentSize bool,
                Severity: Major
                Found in tui/tui.go - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (a *StoredAnalyzer) ResetProgress() {
    a.progress = &common.CurrentProgress{}
    a.progressChan = make(chan common.CurrentProgress, 1)
    a.progressOutChan = make(chan common.CurrentProgress, 1)
    a.progressDoneChan = make(chan struct{})
                  Severity: Major
                  Found in pkg/analyze/stored.go and 1 other location - About 1 hr to fix
                  pkg/analyze/parallel.go on lines 59..66

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 136.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (a *ParallelAnalyzer) ResetProgress() {
    a.progress = &common.CurrentProgress{}
    a.progressChan = make(chan common.CurrentProgress, 1)
    a.progressOutChan = make(chan common.CurrentProgress, 1)
    a.progressDoneChan = make(chan struct{})
                  Severity: Major
                  Found in pkg/analyze/parallel.go and 1 other location - About 1 hr to fix
                  pkg/analyze/stored.go on lines 61..68

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 136.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method ParallelAnalyzer.processDir has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
                  Open

                  func (a *ParallelAnalyzer) processDir(path string) *Dir {
    var (
        file       *File
        err        error
        totalSize  int64
                  Severity: Minor
                  Found in pkg/analyze/parallel.go - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func CreateAnalyzer() *ParallelAnalyzer {
    return &ParallelAnalyzer{
        progress: &common.CurrentProgress{
            ItemCount: 0,
            TotalSize: int64(0),
                  Severity: Major
                  Found in pkg/analyze/parallel.go and 1 other location - About 1 hr to fix
                  pkg/analyze/sequential.go on lines 26..38

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 133.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func CreateSeqAnalyzer() *SequentialAnalyzer {
    return &SequentialAnalyzer{
        progress: &common.CurrentProgress{
            ItemCount: 0,
            TotalSize: int64(0),
                  Severity: Major
                  Found in pkg/analyze/sequential.go and 1 other location - About 1 hr to fix
                  pkg/analyze/parallel.go on lines 29..41

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 133.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method UI.showFile has 10 return statements (exceeds 4 allowed).
                  Open

                  func (ui *UI) showFile() *tview.TextView {
    if ui.currentDir == nil {
        return nil
    }
                  Severity: Major
                  Found in tui/actions.go - About 1 hr to fix

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                    func (a *ParallelAnalyzer) updateProgress() {
    for {
        select {
        case <-a.progressDoneChan:
            return
                    Severity: Major
                    Found in pkg/analyze/parallel.go and 2 other locations - About 1 hr to fix
                    pkg/analyze/sequential.go on lines 163..179
                    pkg/analyze/stored.go on lines 194..210

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 128.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                    func (a *SequentialAnalyzer) updateProgress() {
    for {
        select {
        case <-a.progressDoneChan:
            return
                    Severity: Major
                    Found in pkg/analyze/sequential.go and 2 other locations - About 1 hr to fix
                    pkg/analyze/parallel.go on lines 187..203
                    pkg/analyze/stored.go on lines 194..210

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 128.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language