Sign upLogin

dundee/gdu

View on GitHub
Star
tui/actions.go

Summary

Maintainability
B
7 hrs
Test Coverage

Method UI.showFile has 70 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (ui *UI) showFile() *tview.TextView {
    if ui.currentDir == nil {
        return nil
    }
Severity: Minor
Found in tui/actions.go - About 1 hr to fix

    Method UI.deleteSelected has 63 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (ui *UI) deleteSelected(shouldEmpty bool) {
    row, column := ui.table.GetSelection()
    selectedItem := ui.table.GetCell(row, column).GetReference().(fs.Item)

    if ui.deleteInBackground {
    Severity: Minor
    Found in tui/actions.go - About 1 hr to fix

      Method UI.showFile has 10 return statements (exceeds 4 allowed).
      Open

      func (ui *UI) showFile() *tview.TextView {
    if ui.currentDir == nil {
        return nil
    }
      Severity: Major
      Found in tui/actions.go - About 1 hr to fix

        Method UI.showFile has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
        Open

        func (ui *UI) showFile() *tview.TextView {
    if ui.currentDir == nil {
        return nil
    }
        Severity: Minor
        Found in tui/actions.go - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method UI.deleteSelected has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

        func (ui *UI) deleteSelected(shouldEmpty bool) {
    row, column := ui.table.GetSelection()
    selectedItem := ui.table.GetCell(row, column).GetReference().(fs.Item)

    if ui.deleteInBackground {
        Severity: Minor
        Found in tui/actions.go - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                for _, item := range deleteItems {
            if err := deleteFun(currentDir, item); err != nil {
                msg := "Can't " + action + " " + tview.Escape(selectedItem.GetName())
                ui.app.QueueUpdateDraw(func() {
                    ui.pages.RemovePage(acting)
        Severity: Major
        Found in tui/actions.go and 2 other locations - About 1 hr to fix
        tui/background.go on lines 62..74
        tui/marked.go on lines 82..94

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 139.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status