Sign upLogin

dunkelfrosch/phpcoverfish

View on GitHub
Star

Showing 24 of 24 total issues

ArrayCollection has 32 functions (exceeds 20 allowed). Consider refactoring.
Open

class ArrayCollection implements Collection
{
    /**
     * An array containing the entries of this collection.
     *
Severity: Minor
Found in src/PHPCoverFish/Common/ArrayCollection.php - About 4 hrs to fix

    CoverFishPHPUnitTest has 29 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class CoverFishPHPUnitTest
{
    /**
     * @var bool
     */
    Severity: Minor
    Found in src/PHPCoverFish/Common/CoverFishPHPUnitTest.php - About 3 hrs to fix

      BaseCoverFishValidator has 28 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class BaseCoverFishValidator implements BaseCoverFishValidatorInterface
{
    /**
     * @var ArrayCollection
     */
      Severity: Minor
      Found in src/PHPCoverFish/Validator/Base/BaseCoverFishValidator.php - About 3 hrs to fix

        File BaseCoverFishValidator.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php

namespace DF\PHPCoverFish\Validator\Base;

use DF\PHPCoverFish\Common\ArrayCollection;
        Severity: Minor
        Found in src/PHPCoverFish/Validator/Base/BaseCoverFishValidator.php - About 2 hrs to fix

          Method configure has 63 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function configure()
    {
        $this
            ->setName('scan')
            ->setDescription('scan phpunit test files for static code analysis')
          Severity: Major
          Found in src/PHPCoverFish/CoverFishScanCommand.php - About 2 hrs to fix

            BaseCoverFishResult has 23 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class BaseCoverFishResult
{
    /**
     * @var bool
     */
            Severity: Minor
            Found in src/PHPCoverFish/Common/Base/BaseCoverFishResult.php - About 2 hrs to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          case self::PHPUNIT_NO_DOCBLOCK_FOR_METHOD:
                $coverLine = sprintf('no phpdoc block for %s::%s', $coverMapping->getClassFQN(), $coverMapping->getMethod());
                if (!$noAnsiColors) {
                    $coverLine  = Color::tplNormalColor('no phpdoc block for ');
                    $coverLine .= Color::tplYellowColor($coverMapping->getClassFQN());
              Severity: Major
              Found in src/PHPCoverFish/Common/CoverFishMessageWarning.php and 2 other locations - About 2 hrs to fix
              src/PHPCoverFish/Common/CoverFishMessageError.php on lines 70..82
              src/PHPCoverFish/Common/CoverFishMessageWarning.php on lines 46..58

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 131.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          case self::PHPUNIT_NO_COVERAGE_FOR_METHOD:
                $coverLine = sprintf('no @covers annotation for %s::%s', $coverMapping->getClassFQN(), $coverMapping->getMethod());
                if (!$noAnsiColors) {
                    $coverLine  = Color::tplNormalColor('no @covers annotation for ');
                    $coverLine .= Color::tplYellowColor($coverMapping->getClassFQN());
              Severity: Major
              Found in src/PHPCoverFish/Common/CoverFishMessageWarning.php and 2 other locations - About 2 hrs to fix
              src/PHPCoverFish/Common/CoverFishMessageError.php on lines 70..82
              src/PHPCoverFish/Common/CoverFishMessageWarning.php on lines 60..72

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 131.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                          case self::PHPUNIT_REFLECTION_CLASS_NOT_FOUND:
                $coverLine = sprintf('@covers %s::%s', $coverMapping->getClassFQN(), $coverMapping->getMethod());
                if (!$noAnsiColors) {
                    $coverLine  = Color::tplNormalColor('@covers ');
                    $coverLine .= Color::tplMarkFailure($coverMapping->getClassFQN());
              Severity: Major
              Found in src/PHPCoverFish/Common/CoverFishMessageError.php and 2 other locations - About 2 hrs to fix
              src/PHPCoverFish/Common/CoverFishMessageWarning.php on lines 46..58
              src/PHPCoverFish/Common/CoverFishMessageWarning.php on lines 60..72

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 131.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              BaseScanner has 22 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class BaseScanner
{
    /**
     * @var string
     */
              Severity: Minor
              Found in src/PHPCoverFish/Base/BaseScanner.php - About 2 hrs to fix

                CoverFishResult has 22 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class CoverFishResult extends BaseCoverFishResult
{
    /**
     * @var ArrayCollection
     */
                Severity: Minor
                Found in src/PHPCoverFish/Common/CoverFishResult.php - About 2 hrs to fix

                  Method getErrorStreamTemplate has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getErrorStreamTemplate(CoverFishMapping $coverMapping, $noAnsiColors = false)
    {
        $coverLine = null;
        switch ($this->getMessageCode()) {
            case self::PHPUNIT_REFLECTION_CLASS_NOT_FOUND:
                  Severity: Major
                  Found in src/PHPCoverFish/Common/CoverFishMessageError.php - About 2 hrs to fix

                    CoverFishHelper has 21 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    class CoverFishHelper
{
    const PHPUNIT_ID_INTERFACE = 'PHPUnit_Framework_Test',
          PHPUNIT_ID_CLASS = 'PHPUnit_Framework_TestCase';
                    Severity: Minor
                    Found in src/PHPCoverFish/Common/CoverFishHelper.php - About 2 hrs to fix

                      Function getErrorStreamTemplate has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function getErrorStreamTemplate(CoverFishMapping $coverMapping, $noAnsiColors = false)
    {
        $coverLine = null;
        switch ($this->getMessageCode()) {
            case self::PHPUNIT_REFLECTION_CLASS_NOT_FOUND:
                      Severity: Minor
                      Found in src/PHPCoverFish/Common/CoverFishMessageError.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function writeSingleTestResult has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          private function writeSingleTestResult(
        CoverFishPHPUnitFile $coverFishUnitFile,
        CoverFishResult $coverFishResult
    ) {
                      Severity: Minor
                      Found in src/PHPCoverFish/Common/CoverFishOutput.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method validateReflectionClassForAccessorVisibility has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function validateReflectionClassForAccessorVisibility($classFQN, $accessor)
    {
        $reflectionClass = $this->getReflectionClass($classFQN);
        if ($reflectionClass instanceof CoverFishMessageError) {
            return $reflectionClass;
                      Severity: Minor
                      Found in src/PHPCoverFish/Validator/Base/BaseCoverFishValidator.php - About 1 hr to fix

                        Method writeProgress has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            protected function writeProgress($status)
    {
        $this->resetJsonResult();

        switch ($status) {
                        Severity: Minor
                        Found in src/PHPCoverFish/Common/Base/BaseCoverFishOutput.php - About 1 hr to fix

                          Method getWarningStreamTemplate has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function getWarningStreamTemplate(CoverFishMapping $coverMapping, $noAnsiColors = false)
    {
        $coverLine = null;
        switch ($this->getMessageCode()) {
            case self::PHPUNIT_NO_COVERAGE_FOR_METHOD:
                          Severity: Minor
                          Found in src/PHPCoverFish/Common/CoverFishMessageWarning.php - About 1 hr to fix

                            Function writeSingleMappingResult has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                            Open

                                private function writeSingleMappingResult(
        CoverFishPHPUnitTest $coverFishTest,
        CoverFishResult $coverFishResult
    ) {
        /** @var CoverFishMapping $coverMappings */
                            Severity: Minor
                            Found in src/PHPCoverFish/Common/CoverFishOutput.php - About 55 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function validateReflectionClassForAccessorVisibility has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function validateReflectionClassForAccessorVisibility($classFQN, $accessor)
    {
        $reflectionClass = $this->getReflectionClass($classFQN);
        if ($reflectionClass instanceof CoverFishMessageError) {
            return $reflectionClass;
                            Severity: Minor
                            Found in src/PHPCoverFish/Validator/Base/BaseCoverFishValidator.php - About 55 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language