Sign upLogin

duoshuo/php-cassandra

View on GitHub
Star

Showing 25 of 25 total issues

Method getData has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getData() {
        $this->_stream->offset(0);
        $data = [];
        $data['code'] = $this->_stream->readInt();
Severity: Major
Found in src/Response/Error.php - About 2 hrs to fix

    StreamReader has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class StreamReader {

    /**
     * @var string
     */
    Severity: Minor
    Found in src/Response/StreamReader.php - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
namespace Cassandra\Type;

class PhpFloat extends Base{
    /**
      Severity: Major
      Found in src/Type/PhpFloat.php and 1 other location - About 2 hrs to fix
      src/Type/Double.php on lines 1..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 132.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
namespace Cassandra\Type;

class Double extends Base{
      Severity: Major
      Found in src/Type/Double.php and 1 other location - About 2 hrs to fix
      src/Type/PhpFloat.php on lines 1..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 132.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function _connect has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function _connect() {
        foreach($this->_nodes as $options){
            if (is_string($options)){
                if (!preg_match('/^(((tcp|udp|unix|ssl|tls):\/\/)?[\w\.\-]+)(\:(\d+))?/i', $options, $matches))
                    throw new Exception('Invalid host: ' . $options);
      Severity: Minor
      Found in src/Connection.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getData has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getData() {
        $this->_stream->offset(0);
        $data = [];
        $data['code'] = $this->_stream->readInt();
      Severity: Minor
      Found in src/Response/Error.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method readType has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function readType(){
        $type = $this->readShort();
        switch ($type) {
            case Type\Base::CUSTOM:
                return [
      Severity: Minor
      Found in src/Response/StreamReader.php - About 1 hr to fix

        Function valuesBinary has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function valuesBinary(array $values, $namesForValues = false) {
        $valuesBinary = pack('n', count($values));
        
        $index = 0;
        foreach($values as $name => $value) {
        Severity: Minor
        Found in src/Request/Request.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method valuesBinary has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function valuesBinary(array $values, $namesForValues = false) {
        $valuesBinary = pack('n', count($values));
        
        $index = 0;
        foreach($values as $name => $value) {
        Severity: Minor
        Found in src/Request/Request.php - About 1 hr to fix

          Method _readMetadata has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function _readMetadata() {
        $metadata = [
            'flags' => $this->_stream->readInt(),
            'columns_count' => $this->_stream->readInt(),
        ];
          Severity: Minor
          Found in src/Response/Result.php - About 1 hr to fix

            Method _getResponse has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function _getResponse() {
        $version = unpack('C', $this->_node->read(1))[1];
        switch($version) {
            case 0x83:
                $header = unpack('Cflags/nstream/Copcode/Nlength', $this->_node->read(8));
            Severity: Minor
            Found in src/Connection.php - About 1 hr to fix

              Function _readMetadata has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function _readMetadata() {
        $metadata = [
            'flags' => $this->_stream->readInt(),
            'columns_count' => $this->_stream->readInt(),
        ];
              Severity: Minor
              Found in src/Response/Result.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method queryParameters has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function queryParameters($consistency, array $values = [], array $options = []){
        $flags = 0;
        $optional = '';
        
        if (!empty($values)) {
              Severity: Minor
              Found in src/Request/Request.php - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function appendQuery($cql, array $values = []) {
        $binary = pack('C', 0);
    
        $binary .= pack('N', strlen($cql)) . $cql;
        $binary .= Request::valuesBinary($values, !empty($this->_options['names_for_values']));
                Severity: Major
                Found in src/Request/Batch.php and 1 other location - About 1 hr to fix
                src/Request/Batch.php on lines 80..89

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 101.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function appendQueryId($queryId, array $values = []) {
        $binary = pack('C', 1);
        
        $binary .= pack('n', strlen($queryId)) . $queryId;
        $binary .= Request::valuesBinary($values, !empty($this->_options['names_for_values']));
                Severity: Major
                Found in src/Request/Batch.php and 1 other location - About 1 hr to fix
                src/Request/Batch.php on lines 63..72

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 101.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function fetchPairs has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function fetchPairs(){
        if ($this->getKind() !== self::ROWS){
            throw new Exception('Unexpected Response: ' . $this->getKind());
        }
        $this->_stream->offset(4);
                Severity: Minor
                Found in src/Response/Result.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function fetchCol has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function fetchCol($index = 0){
        if ($this->getKind() !== self::ROWS){
            throw new Exception('Unexpected Response: ' . $this->getKind());
        }
        $this->_stream->offset(4);
                Severity: Minor
                Found in src/Response/Result.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function queryParameters has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function queryParameters($consistency, array $values = [], array $options = []){
        $flags = 0;
        $optional = '';
        
        if (!empty($values)) {
                Severity: Minor
                Found in src/Request/Request.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Open

                                return $data;
                Severity: Major
                Found in src/Response/StreamReader.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return [
                    'change' => $this->_stream->readString(),
                    'keyspace' => $this->_stream->readString(),
                    'table' => $this->_stream->readString()
                ];
                  Severity: Major
                  Found in src/Response/Result.php - About 30 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language