Sign upLogin

duse-io/duse.rb

View on GitHub
Star

Showing 12 of 12 total issues

Class Command has 36 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Command
      attr_reader :output, :input
      attr_accessor :arguments, :force_interactive

      extend Parser
Severity: Minor
Found in lib/duse/cli/command.rb - About 4 hrs to fix

    Method check_arity has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def check_arity(method, *args)
        return unless method.respond_to? :parameters
        method.parameters.each do |type, name|
          return if type == :rest
          wrong_args("few") unless args.shift or type == :opt or type == :block
    Severity: Minor
    Found in lib/duse/cli/command.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method choose_key has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def choose_key(options = { allow_generate: true })
      key = nil
      generate_option = 'Generate a new one'
      choose_myself_option = 'Let me choose it myself'
      choices = possible_ssh_keys
    Severity: Minor
    Found in lib/duse/cli/key_helper.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method usage_for has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def usage_for(prefix, method)
        usage = "duse #{prefix}"
        method = method(method)
        if method.respond_to? :parameters
          method.parameters.each do |type, name|
    Severity: Minor
    Found in lib/duse/cli/command.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    module Duse
  module CLI
    class FolderRemove < ApiCommand
      description 'Delete a folder (does not delete the children)'
    Severity: Minor
    Found in lib/duse/cli/folder_remove.rb and 1 other location - About 35 mins to fix
    lib/duse/cli/secret_remove.rb on lines 3..16

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    module Duse
  module CLI
    class SecretRemove < ApiCommand
      description 'Delete a secret'
    Severity: Minor
    Found in lib/duse/cli/secret_remove.rb and 1 other location - About 35 mins to fix
    lib/duse/cli/folder_remove.rb on lines 3..16

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method build has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def build
        result = {}
        result[:title] = @values[:title] if @values[:title]
        result[:folder_id] = @values[:folder_id].to_i if @values[:folder_id]
        if @values[:secret_text]
    Severity: Minor
    Found in lib/duse/client/secret.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def run
        self.title  ||= terminal.ask 'What do you want to call this secret? '
        self.secret = File.read(self.file) if file?
        self.secret = SecretGenerator.new.generated_password if generate_secret?
        self.secret ||= terminal.ask 'Secret to save: '
    Severity: Minor
    Found in lib/duse/cli/secret_add.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_attribute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.add_attribute(name)
        dummy = self.new

        attributes << name
        define_method(name) { load_attribute(name) } unless dummy.respond_to? name
    Severity: Minor
    Found in lib/duse/client/entity.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method instance_from has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def instance_from(entity, hash)
        instance = entity.new
        instance.curry = curry_by_entity(entity)
        entity.attributes.each do |attribute|
          if hash.has_key? attribute
    Severity: Minor
    Found in lib/duse/client/session.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    module Duse
  module CLI
    class AccountResendConfirmation < ApiCommand
      description 'resend the confirmation email for your account'
    Severity: Minor
    Found in lib/duse/cli/account_resend_confirmation.rb and 1 other location - About 15 mins to fix
    lib/duse/cli/account_password_reset.rb on lines 3..15

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    module Duse
  module CLI
    class AccountPasswordReset < ApiCommand
      description 'request a reset of your password'
    Severity: Minor
    Found in lib/duse/cli/account_password_reset.rb and 1 other location - About 15 mins to fix
    lib/duse/cli/account_resend_confirmation.rb on lines 3..15

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language