Sign upLogin

dustin-H/telaviv

View on GitHub
Star

Showing 24 of 24 total issues

Function response has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  let response = (component, err, superres) => {
    k--
    if (err != null) {
      if (mostImportantError == null) {
        mostImportantError = err
Severity: Minor
Found in src/fetch/rest.js - About 1 hr to fix

    Function loadComponentIfNecessary has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    var loadComponentIfNecessary = function(id, cb) {
  if (store[id] == null) {
    store[id] = {}
    store[id].url = '/.static/components/' + id + '.js'
    store[id].callbacks = []
    Severity: Minor
    Found in src/app/loader/client/loader.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function render has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      render() {
    const {to, activeClassName, activeStyle, ...props} = this.props

    // Ignore if rendered outside the context of router, simplifies unit testing.
    const {telaviv} = this.context
    Severity: Minor
    Found in src/utils/Link.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function matchPattern has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function matchPattern(pattern, pathname) {
  // Make leading slashes consistent between pattern and pathname.
  if (pattern.charAt(0) !== '/') {
    pattern = `/${pattern}`
  }
    Severity: Minor
    Found in src/router/pathMatcher.js - About 1 hr to fix

      Function loadComponentIfNecessary has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var loadComponentIfNecessary = function(id, cb) {
  if (store[id] == null) {
    store[id] = {}
    store[id].url = '/.static/components/' + id + '.js'
    store[id].callbacks = []
      Severity: Minor
      Found in src/app/loader/client/loader.js - About 1 hr to fix

        Function _compilePattern has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function _compilePattern(pattern) {
  let regexpSource = ''
  const paramNames = []
  const tokens = []
        Severity: Minor
        Found in src/router/pathMatcher.js - About 1 hr to fix

          Function matchPattern has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

          function matchPattern(pattern, pathname) {
  // Make leading slashes consistent between pattern and pathname.
  if (pattern.charAt(0) !== '/') {
    pattern = `/${pattern}`
  }
          Severity: Minor
          Found in src/router/pathMatcher.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _compilePattern has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          function _compilePattern(pattern) {
  let regexpSource = ''
  const paramNames = []
  const tokens = []
          Severity: Minor
          Found in src/router/pathMatcher.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function default has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export default function() {
  return (req, res, next) => {
    if (cache[req.url] != null) {
      let entry = cache[req.url]
      if (entry.t > Date.now()) {
          Severity: Minor
          Found in src/middleware/simpleCache.js - About 1 hr to fix

            Function default has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export default function() {
  return (req, res, next) => {
    if (req.telaviv.route.route.redirect != null) {
      req.telaviv.type = 'redirect'
      return next()
            Severity: Minor
            Found in src/middleware/routeTypeParser.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                if (lastIndex !== pattern.length) {
    tokens.push(pattern.slice(lastIndex, pattern.length))
    regexpSource += escapeSource(pattern.slice(lastIndex, pattern.length))
  }
              Severity: Minor
              Found in src/router/pathMatcher.js and 1 other location - About 50 mins to fix
              src/router/pathMatcher.js on lines 29..32

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 52.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (match.index !== lastIndex) {
      tokens.push(pattern.slice(lastIndex, match.index))
      regexpSource += escapeSource(pattern.slice(lastIndex, match.index))
    }
              Severity: Minor
              Found in src/router/pathMatcher.js and 1 other location - About 50 mins to fix
              src/router/pathMatcher.js on lines 54..57

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 52.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid deeply nested control flow statements.
              Open

                        if (route[type][j].component) {
            if (c.components[c.theme+'/'+route[type][j].component] == null) {
              c.components[c.theme+'/'+route[type][j].component] = 'c' + c.componentCounter.toString(36) + '-'
              c.componentCounter++
            }
              Severity: Major
              Found in src/config/compileConfig.js - About 45 mins to fix

                Function generateCacheHeader has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                var generateCacheHeader = function(c) {
  if (c.noStore === true && c.noCache === true) {
    return 'no-cache, no-store'
  }
  if (c.noCache === true) {
                Severity: Minor
                Found in src/fetch/rest.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function handleClick has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  handleClick(event) {
    let allowTransition = true

    /* istanbul ignore if => No need to test this because it's testet in react-router  */
    if (this.props.onClick) {
                Severity: Minor
                Found in src/utils/Link.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    if (req.telaviv.route.route.html5 != null) {
      req.telaviv.type = 'html5'
      return next()
    }
                Severity: Minor
                Found in src/middleware/routeTypeParser.js and 2 other locations - About 40 mins to fix
                src/middleware/routeTypeParser.js on lines 4..7
                src/middleware/routeTypeParser.js on lines 23..26

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    if (req.telaviv.route.route.amphtml != null) {
      req.telaviv.type = 'amphtml'
      return next()
    }
                Severity: Minor
                Found in src/middleware/routeTypeParser.js and 2 other locations - About 40 mins to fix
                src/middleware/routeTypeParser.js on lines 4..7
                src/middleware/routeTypeParser.js on lines 19..22

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    if (req.telaviv.route.route.redirect != null) {
      req.telaviv.type = 'redirect'
      return next()
    }
                Severity: Minor
                Found in src/middleware/routeTypeParser.js and 2 other locations - About 40 mins to fix
                src/middleware/routeTypeParser.js on lines 19..22
                src/middleware/routeTypeParser.js on lines 23..26

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function canCache has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                const canCache = (res) => {
  if (res.statusCode !== 200) {
    return false
  }
  let cc = res.get('cache-control')
                Severity: Minor
                Found in src/middleware/simpleCache.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function matchRoutes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                var matchRoutes = function(routes, pathname) {
  for (var i in routes) {
    var route = routes[i]
    var match = pathMatcher(route.path, pathname)
    if (match.paramValues != null && match.paramNames != null && match.paramValues.length === match.paramNames.length) {
                Severity: Minor
                Found in src/router/matchRoutes.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language