Showing 17 of 24 total issues
Function response
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
let response = (component, err, superres) => {
k--
if (err != null) {
if (mostImportantError == null) {
mostImportantError = err
Function loadComponentIfNecessary
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
var loadComponentIfNecessary = function(id, cb) {
if (store[id] == null) {
store[id] = {}
store[id].url = '/.static/components/' + id + '.js'
store[id].callbacks = []
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function render
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
render() {
const {to, activeClassName, activeStyle, ...props} = this.props
// Ignore if rendered outside the context of router, simplifies unit testing.
const {telaviv} = this.context
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function matchPattern
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
function matchPattern(pattern, pathname) {
// Make leading slashes consistent between pattern and pathname.
if (pattern.charAt(0) !== '/') {
pattern = `/${pattern}`
}
Function loadComponentIfNecessary
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
var loadComponentIfNecessary = function(id, cb) {
if (store[id] == null) {
store[id] = {}
store[id].url = '/.static/components/' + id + '.js'
store[id].callbacks = []
Function _compilePattern
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
function _compilePattern(pattern) {
let regexpSource = ''
const paramNames = []
const tokens = []
Function matchPattern
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
function matchPattern(pattern, pathname) {
// Make leading slashes consistent between pattern and pathname.
if (pattern.charAt(0) !== '/') {
pattern = `/${pattern}`
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _compilePattern
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
function _compilePattern(pattern) {
let regexpSource = ''
const paramNames = []
const tokens = []
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function default
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function() {
return (req, res, next) => {
if (cache[req.url] != null) {
let entry = cache[req.url]
if (entry.t > Date.now()) {
Function default
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function() {
return (req, res, next) => {
if (req.telaviv.route.route.redirect != null) {
req.telaviv.type = 'redirect'
return next()
Avoid deeply nested control flow statements. Open
if (route[type][j].component) {
if (c.components[c.theme+'/'+route[type][j].component] == null) {
c.components[c.theme+'/'+route[type][j].component] = 'c' + c.componentCounter.toString(36) + '-'
c.componentCounter++
}
Function generateCacheHeader
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
var generateCacheHeader = function(c) {
if (c.noStore === true && c.noCache === true) {
return 'no-cache, no-store'
}
if (c.noCache === true) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function handleClick
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
handleClick(event) {
let allowTransition = true
/* istanbul ignore if => No need to test this because it's testet in react-router */
if (this.props.onClick) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function canCache
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
const canCache = (res) => {
if (res.statusCode !== 200) {
return false
}
let cc = res.get('cache-control')
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function matchRoutes
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
var matchRoutes = function(routes, pathname) {
for (var i in routes) {
var route = routes[i]
var match = pathMatcher(route.path, pathname)
if (match.paramValues != null && match.paramNames != null && match.paramValues.length === match.paramNames.length) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
return false // default => No cache!
Avoid too many return
statements within this function. Open
return 0