Sign upLogin

dvinciguerra/business-br

View on GitHub
Star

Showing 123 of 123 total issues

Do not place comments on the same line as the end keyword.
Open

  end # BR
Severity: Minor
Found in lib/business-br/cep/providers/base.rb by rubocop

This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

Example:

# bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

Line is too long. [129/80]
Open

        "#{Regexp.last_match(1)}.#{Regexp.last_match(2)}.#{Regexp.last_match(3)}/#{Regexp.last_match(4)}-#{Regexp.last_match(5)}"
Severity: Minor
Found in lib/business-br/cnpj.rb by rubocop

Line is too long. [102/80]
Open

        "#{Regexp.last_match(1)}#{Regexp.last_match(2)}#{Regexp.last_match(3)}#{Regexp.last_match(4)}"
Severity: Minor
Found in lib/business-br/cpf.rb by rubocop

Do not place comments on the same line as the end keyword.
Open

    end # CEP
Severity: Minor
Found in lib/business-br/cep/providers/base.rb by rubocop

This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

Example:

# bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

Do not place comments on the same line as the end keyword.
Open

end # Business
Severity: Minor
Found in lib/business-br/cep/providers/base.rb by rubocop

This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

Example:

# bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

Do not place comments on the same line as the end keyword.
Open

    end # CEP
Severity: Minor
Found in lib/business-br/cep/providers.rb by rubocop

This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

Example:

# bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

Do not place comments on the same line as the end keyword.
Open

end # Business
Severity: Minor
Found in lib/business-br/cep/providers.rb by rubocop

This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

Example:

# bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

Freeze mutable objects assigned to constants.
Open

    VERSION = '0.12.1'
Severity: Minor
Found in lib/business-br/version.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Useless assignment to variable - cep_type.
Open

cep_type = validator.type(cep) # => 'LOGRADOURO'
Severity: Minor
Found in examples/cep.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Use %q only for strings that contain both single quotes and double quotes.
Open

  spec.summary       = %q[
    Classes for validations and conversions to use in brazilian ruby projects.
  ]
Severity: Minor
Found in business-br.gemspec by rubocop

Do not place comments on the same line as the end keyword.
Open

      end # Providers
Severity: Minor
Found in lib/business-br/cep/providers/republicavirtual.rb by rubocop

This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

Example:

# bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

Missing top-level class documentation comment.
Open

        class Postmon < Base
Severity: Minor
Found in lib/business-br/cep/providers/postmon.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Do not place comments on the same line as the end keyword.
Open

      end # Providers
Severity: Minor
Found in lib/business-br/cep/providers/base.rb by rubocop

This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

Example:

# bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      if cpf =~ /^(\d{3})\.?(\d{3})\.?(\d{3})-?(\d{2})$/
Severity: Minor
Found in lib/business-br/cpf.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

1 trailing blank lines detected.
Open

Severity: Minor
Found in Gemfile by rubocop

Missing top-level class documentation comment.
Open

      class Providers
Severity: Minor
Found in lib/business-br/cep/providers.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

  class CNPJ
Severity: Minor
Found in lib/business-br/cnpj.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Inconsistent indentation detected.
Open

              parse_response(response.body)
Severity: Minor
Found in lib/business-br/cep/providers/republicavirtual.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Missing top-level class documentation comment.
Open

        class RepublicaVirtual < Base
Severity: Minor
Found in lib/business-br/cep/providers/republicavirtual.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [84/80]
Open

              response = Faraday.get("http://api.postmon.com.br/v1/cep/#{@zipcode}")
Severity: Minor
Found in lib/business-br/cep/providers/postmon.rb by rubocop
Severity
Category
Status
Source
Language