Sign upLogin

dxania/Send_IT_APIs

View on GitHub
Star
app/routes/parcel_routes.py

Summary

Maintainability
B
4 hrs
Test Coverage

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@app.route('/api/v1/parcels/<int:parcel_id>/present_location', methods = ['PUT'])
@jwt_required
def change_location(parcel_id):
    """Change the present location of a parcel delivery order"""
    return Parcel_Controller.change_present_location(parcel_id)
Severity: Major
Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
app/routes/parcel_routes.py on lines 18..22
app/routes/parcel_routes.py on lines 24..28
app/routes/parcel_routes.py on lines 30..34
app/routes/parcel_routes.py on lines 36..40
app/routes/parcel_routes.py on lines 42..46
app/routes/parcel_routes.py on lines 48..52
app/routes/parcel_routes.py on lines 62..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@app.route('/api/v1/parcels/<int:parcel_id>', methods = ['GET'])
@jwt_required
def get_parcel(parcel_id):
    """Retrieve a particular parcel"""
    return Parcel_Controller.get_parcel(parcel_id)
Severity: Major
Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
app/routes/parcel_routes.py on lines 18..22
app/routes/parcel_routes.py on lines 24..28
app/routes/parcel_routes.py on lines 30..34
app/routes/parcel_routes.py on lines 36..40
app/routes/parcel_routes.py on lines 42..46
app/routes/parcel_routes.py on lines 55..59
app/routes/parcel_routes.py on lines 62..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@app.route('/api/v1/users/<int:user_id>/parcels/intransit', methods = ['GET'])
@jwt_required
def get_intransit_parcels_by_user(user_id):
    """Retrieve all intransit parcels by a specific user"""
    return Parcel_Controller.get_intransit_parcels_by_user(user_id)
Severity: Major
Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
app/routes/parcel_routes.py on lines 18..22
app/routes/parcel_routes.py on lines 24..28
app/routes/parcel_routes.py on lines 36..40
app/routes/parcel_routes.py on lines 42..46
app/routes/parcel_routes.py on lines 48..52
app/routes/parcel_routes.py on lines 55..59
app/routes/parcel_routes.py on lines 62..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@app.route('/api/v1/users/<int:user_id>/parcels/pending', methods = ['GET'])
@jwt_required
def get_pending_parcels_by_user(user_id):
    """Retrieve all pending parcels by a specific user"""
    return Parcel_Controller.get_pending_parcels_by_user(user_id)
Severity: Major
Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
app/routes/parcel_routes.py on lines 18..22
app/routes/parcel_routes.py on lines 24..28
app/routes/parcel_routes.py on lines 30..34
app/routes/parcel_routes.py on lines 42..46
app/routes/parcel_routes.py on lines 48..52
app/routes/parcel_routes.py on lines 55..59
app/routes/parcel_routes.py on lines 62..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@app.route('/api/v1/users/<int:user_id>/parcels/cancelled', methods = ['GET'])
@jwt_required
def get_cancelled_parcels_by_user(user_id):
    """Retrieve all cancelled parcels by a specific user"""
    return Parcel_Controller.get_cancelled_parcels_by_user(user_id)
Severity: Major
Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
app/routes/parcel_routes.py on lines 18..22
app/routes/parcel_routes.py on lines 24..28
app/routes/parcel_routes.py on lines 30..34
app/routes/parcel_routes.py on lines 36..40
app/routes/parcel_routes.py on lines 48..52
app/routes/parcel_routes.py on lines 55..59
app/routes/parcel_routes.py on lines 62..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@app.route('/api/v1/users/<int:user_id>/parcels', methods = ['GET'])
@jwt_required
def get_parcels_by_user(user_id):
    """Retrieve all parcels by a specific user"""
    return Parcel_Controller.get_parcels_by_user(user_id)
Severity: Major
Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
app/routes/parcel_routes.py on lines 24..28
app/routes/parcel_routes.py on lines 30..34
app/routes/parcel_routes.py on lines 36..40
app/routes/parcel_routes.py on lines 42..46
app/routes/parcel_routes.py on lines 48..52
app/routes/parcel_routes.py on lines 55..59
app/routes/parcel_routes.py on lines 62..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@app.route('/api/v1/users/<int:user_id>/parcels/delivered', methods = ['GET'])
@jwt_required
def get_delivered_parcels_by_user(user_id):
    """Retrieve all delivered parcels by a specific user"""
    return Parcel_Controller.get_delivered_parcels_by_user(user_id)
Severity: Major
Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
app/routes/parcel_routes.py on lines 18..22
app/routes/parcel_routes.py on lines 30..34
app/routes/parcel_routes.py on lines 36..40
app/routes/parcel_routes.py on lines 42..46
app/routes/parcel_routes.py on lines 48..52
app/routes/parcel_routes.py on lines 55..59
app/routes/parcel_routes.py on lines 62..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@app.route('/api/v1/parcels/<int:parcel_id>/status', methods = ['PUT'])
@jwt_required
def change_status(parcel_id):
    """Cancel a particular parcel delivery order by a user"""
    return Parcel_Controller.change_parcel_status(parcel_id)
Severity: Major
Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
app/routes/parcel_routes.py on lines 18..22
app/routes/parcel_routes.py on lines 24..28
app/routes/parcel_routes.py on lines 30..34
app/routes/parcel_routes.py on lines 36..40
app/routes/parcel_routes.py on lines 42..46
app/routes/parcel_routes.py on lines 48..52
app/routes/parcel_routes.py on lines 55..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status