Sign upLogin

dxania/Send_IT_APIs

View on GitHub
Star
app/validator.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function validate_parcel has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_parcel(parcel):
        messages = []
        error_dict = {'message':messages}

        variables = ['description', 'recipient_name', 'pickup_location', 'destination', 'recipient_mobile', 'weight']
Severity: Minor
Found in app/validator.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate_status has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_status(parcel, status):
        statuses = ['pending','intransit','cancelled', 'delivered']
      
        if parcel[9] == 'cancelled' or parcel[9] == 'delivered':
            return jsonify({'message':'The parcel was either cancelled or delivered, status can not be changed'}), 400
Severity: Minor
Found in app/validator.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate_user_credentials has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def validate_user_credentials(user_name, user_email, user_password, user_mobile):
        
        if not user_email:
            return jsonify({'message':"Email required"}), 400
        if not user_password:
Severity: Minor
Found in app/validator.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                return jsonify({'message':'User name must be letters'}), 400
Severity: Major
Found in app/validator.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return jsonify({'message':"User name required"}), 400
    Severity: Major
    Found in app/validator.py - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status