Sign upLogin

dxania/Send_IT_APIs

View on GitHub
Star

Showing 46 of 46 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def get_all_parcels(self):
        get_parcels = "SELECT * FROM parcels ORDER BY parcel_id ASC"
        self.cursor.execute(get_parcels)
        result = self.cursor.fetchall()
        return result
Severity: Minor
Found in app/controllers/db.py and 1 other location - About 50 mins to fix
app/controllers/db.py on lines 138..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                        if usermail == a_user[2]:
                            return jsonify({'message':"Email belongs to another account"}), 400
                        db.edit_user(usermail, usermobile, defaultpickup, user_name)
Severity: Major
Found in app/controllers/user_controller.py - About 45 mins to fix

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    @app.route('/api/v1/parcels/<int:parcel_id>/present_location', methods = ['PUT'])
@jwt_required
def change_location(parcel_id):
    """Change the present location of a parcel delivery order"""
    return Parcel_Controller.change_present_location(parcel_id)
    Severity: Major
    Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
    app/routes/parcel_routes.py on lines 18..22
    app/routes/parcel_routes.py on lines 24..28
    app/routes/parcel_routes.py on lines 30..34
    app/routes/parcel_routes.py on lines 36..40
    app/routes/parcel_routes.py on lines 42..46
    app/routes/parcel_routes.py on lines 48..52
    app/routes/parcel_routes.py on lines 62..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    @app.route('/api/v1/parcels/<int:parcel_id>', methods = ['GET'])
@jwt_required
def get_parcel(parcel_id):
    """Retrieve a particular parcel"""
    return Parcel_Controller.get_parcel(parcel_id)
    Severity: Major
    Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
    app/routes/parcel_routes.py on lines 18..22
    app/routes/parcel_routes.py on lines 24..28
    app/routes/parcel_routes.py on lines 30..34
    app/routes/parcel_routes.py on lines 36..40
    app/routes/parcel_routes.py on lines 42..46
    app/routes/parcel_routes.py on lines 55..59
    app/routes/parcel_routes.py on lines 62..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function switch_user_role has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def switch_user_role(user_id):
        current_user = get_jwt_identity()
        print(current_user)
        if current_user.get('username') == 'admin':
            user = db.get_user_by_id(user_id)
    Severity: Minor
    Found in app/controllers/user_controller.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function change_parcel_status has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def change_parcel_status(parcel_id):
        """Change the status of a parcel delivery order"""
        current_user = get_jwt_identity()
        parcel = db.get_a_parcel(parcel_id)
        if parcel:
    Severity: Minor
    Found in app/controllers/parcel_controller.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    @app.route('/api/v1/users/<int:user_id>/parcels/intransit', methods = ['GET'])
@jwt_required
def get_intransit_parcels_by_user(user_id):
    """Retrieve all intransit parcels by a specific user"""
    return Parcel_Controller.get_intransit_parcels_by_user(user_id)
    Severity: Major
    Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
    app/routes/parcel_routes.py on lines 18..22
    app/routes/parcel_routes.py on lines 24..28
    app/routes/parcel_routes.py on lines 36..40
    app/routes/parcel_routes.py on lines 42..46
    app/routes/parcel_routes.py on lines 48..52
    app/routes/parcel_routes.py on lines 55..59
    app/routes/parcel_routes.py on lines 62..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    @app.route('/api/v1/users/<int:user_id>/parcels/pending', methods = ['GET'])
@jwt_required
def get_pending_parcels_by_user(user_id):
    """Retrieve all pending parcels by a specific user"""
    return Parcel_Controller.get_pending_parcels_by_user(user_id)
    Severity: Major
    Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
    app/routes/parcel_routes.py on lines 18..22
    app/routes/parcel_routes.py on lines 24..28
    app/routes/parcel_routes.py on lines 30..34
    app/routes/parcel_routes.py on lines 42..46
    app/routes/parcel_routes.py on lines 48..52
    app/routes/parcel_routes.py on lines 55..59
    app/routes/parcel_routes.py on lines 62..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function login has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def login():
        db = DatabaseConnection()
        user_input = request.get_json(force=True)        
        username = user_input.get("user_name")
        password = user_input.get("user_password")
    Severity: Minor
    Found in app/controllers/user_controller.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    @app.route('/api/v1/users/<int:user_id>/parcels/cancelled', methods = ['GET'])
@jwt_required
def get_cancelled_parcels_by_user(user_id):
    """Retrieve all cancelled parcels by a specific user"""
    return Parcel_Controller.get_cancelled_parcels_by_user(user_id)
    Severity: Major
    Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
    app/routes/parcel_routes.py on lines 18..22
    app/routes/parcel_routes.py on lines 24..28
    app/routes/parcel_routes.py on lines 30..34
    app/routes/parcel_routes.py on lines 36..40
    app/routes/parcel_routes.py on lines 48..52
    app/routes/parcel_routes.py on lines 55..59
    app/routes/parcel_routes.py on lines 62..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function get_parcels_by_user has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_parcels_by_user(user_id):
        """Retrieve all parcels by a specific user"""
        parcel_list = []
        current_user = get_jwt_identity()
        if current_user.get('id') == user_id or current_user.get('role') == True:
    Severity: Minor
    Found in app/controllers/parcel_controller.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    @app.route('/api/v1/users/<int:user_id>/parcels', methods = ['GET'])
@jwt_required
def get_parcels_by_user(user_id):
    """Retrieve all parcels by a specific user"""
    return Parcel_Controller.get_parcels_by_user(user_id)
    Severity: Major
    Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
    app/routes/parcel_routes.py on lines 24..28
    app/routes/parcel_routes.py on lines 30..34
    app/routes/parcel_routes.py on lines 36..40
    app/routes/parcel_routes.py on lines 42..46
    app/routes/parcel_routes.py on lines 48..52
    app/routes/parcel_routes.py on lines 55..59
    app/routes/parcel_routes.py on lines 62..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    @app.route('/api/v1/users/<int:user_id>/parcels/delivered', methods = ['GET'])
@jwt_required
def get_delivered_parcels_by_user(user_id):
    """Retrieve all delivered parcels by a specific user"""
    return Parcel_Controller.get_delivered_parcels_by_user(user_id)
    Severity: Major
    Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
    app/routes/parcel_routes.py on lines 18..22
    app/routes/parcel_routes.py on lines 30..34
    app/routes/parcel_routes.py on lines 36..40
    app/routes/parcel_routes.py on lines 42..46
    app/routes/parcel_routes.py on lines 48..52
    app/routes/parcel_routes.py on lines 55..59
    app/routes/parcel_routes.py on lines 62..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    @app.route('/api/v1/parcels/<int:parcel_id>/status', methods = ['PUT'])
@jwt_required
def change_status(parcel_id):
    """Cancel a particular parcel delivery order by a user"""
    return Parcel_Controller.change_parcel_status(parcel_id)
    Severity: Major
    Found in app/routes/parcel_routes.py and 7 other locations - About 35 mins to fix
    app/routes/parcel_routes.py on lines 18..22
    app/routes/parcel_routes.py on lines 24..28
    app/routes/parcel_routes.py on lines 30..34
    app/routes/parcel_routes.py on lines 36..40
    app/routes/parcel_routes.py on lines 42..46
    app/routes/parcel_routes.py on lines 48..52
    app/routes/parcel_routes.py on lines 55..59

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

                return jsonify({'message':'You do not have access to this'}), 401
    Severity: Major
    Found in app/controllers/user_controller.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return jsonify({'message':'User name must be letters'}), 400
      Severity: Major
      Found in app/validator.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return jsonify({'message':f"There is no parcel with ID {parcel_id}"}), 404
        Severity: Major
        Found in app/controllers/parcel_controller.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return jsonify({'message':f"There is no parcel with ID {parcel_id}"}), 404
          Severity: Major
          Found in app/controllers/parcel_controller.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return jsonify({'message':"Something went wrong"}), 400
            Severity: Major
            Found in app/controllers/user_controller.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return jsonify({'message': f"{user_name} does not exist"}), 404
              Severity: Major
              Found in app/controllers/user_controller.py - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language