Sign upLogin

dyang/merge_junit_report

View on GitHub
Star

Showing 4 of 4 total issues

Method merge has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

        def merge
          baseline = @reports.first
          @reports.drop(1).each do |report|
            report.elements.each('//testsuite') do |suite_to_merge|
              suite_name = suite_to_merge.attributes['name']
Severity: Minor
Found in lib/fastlane/plugin/merge_junit_report/merger.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method available_options has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def self.available_options
        [
          FastlaneCore::ConfigItem.new(key: :input_files,
                                       env_name: 'MERGE_JUNIT_REPORT_INPUT_FILES',
                                       description: 'A list of junit report files to merge from',
Severity: Minor
Found in lib/fastlane/plugin/merge_junit_report/actions/merge_junit_report_action.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Extra empty line detected before the rescue.
Open


  rescue => e
Severity: Minor
Found in fastlane/Fastfile by rubocop

This cops checks if empty lines exist around the bodies of begin sections. This cop doesn't check empty lines at begin body beginning/end and around method definition body. Style/EmptyLinesAroundBeginBody or Style/EmptyLinesAroundMethodBody can be used for this purpose.

Example:

# good

begin
  do_something
rescue
  do_something2
else
  do_something3
ensure
  do_something4
end

# good

def foo
  do_something
rescue
  do_something2
end

# bad

begin
  do_something

rescue

  do_something2

else

  do_something3

ensure

  do_something4
end

# bad

def foo
  do_something

rescue

  do_something2
end

Avoid rescuing without specifying an error class.
Open

  rescue => e
Severity: Minor
Found in fastlane/Fastfile by rubocop

This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

Example: EnforcedStyle: implicit

# `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

Example: EnforcedStyle: explicit (default)

# `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end
Severity
Category
Status
Source
Language