Sign upLogin

dynamic/silverstripe-locator-frontend-react

View on GitHub
Star

Showing 8 of 11 total issues

Function reducer has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function reducer(state = defaultState, action) {
  switch (action.type) {
    case ActionType.STORE_CREATED: {
      return {
        ...state,
Severity: Minor
Found in client/src/js/reducers/settingsReducer.js - About 1 hr to fix

    Function reducer has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function reducer(state = defaultState, action) {
  switch (action.type) {
    case ActionType.MARKER_CLICK:
      return {
        ...state,
    Severity: Minor
    Found in client/src/js/reducers/mapReducer.js - About 1 hr to fix

      Method customScript has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function customScript()
    {
        $radii = $this->owner->getShowRadius() ? $this->owner->getRadii() : [];
        $radiiString = json_encode($radii);
      Severity: Minor
      Found in src/Extensions/LocatorControllerExtension.php - About 1 hr to fix

        Function render has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          render() {
    const {center, defaultCenter, mapStyle, clusters, clusterStyles} = this.props;

    // we don't want a center if it is invalid
    const opts = {};
        Severity: Minor
        Found in client/src/js/containers/map/Map.jsx - About 1 hr to fix

          Method getSearchIconImage has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function getSearchIconImage($svg = true)
    {
        $folders = [
            'client/dist/img/',
            'client/dist/images/',
          Severity: Minor
          Found in src/Extensions/LocatorControllerExtension.php - About 1 hr to fix

            Function render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              render() {
    const { count, page, goToPage, PaginationEnd } = this.props;
    const previousClasses = page <= 1 ? "page-item disabled" : "page-item";
    const previousAction = page <= 1 ? () => {} : () => goToPage(page - 1);
            Severity: Minor
            Found in client/src/js/components/list/Pagination.jsx - About 1 hr to fix

              Function getSearchIconImage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function getSearchIconImage($svg = true)
    {
        $folders = [
            'client/dist/img/',
            'client/dist/images/',
              Severity: Minor
              Found in src/Extensions/LocatorControllerExtension.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Selector infoBox should be written in lowercase with hyphens
              Open

                .infoBox {
              Severity: Minor
              Found in client/src/scss/components/_map.scss by scss-lint
              Severity
              Category
              Status
              Source
              Language