Sign upLogin

dzarezenko/hitbtc-api

View on GitHub
Star

Showing 31 of 31 total issues

Method exec has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function exec($request, array $params = [], $method = "GET") {
        usleep(100000);

        $requestUri = HitBtcAPIConf::getAPIUrlSegment(HitBtcAPIConf::SEGMENT_TYPE_TRADING, $this->apiVersion)
                    . $request;
Severity: Minor
Found in src/tools/Request.php - About 1 hr to fix

    Function exec has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function exec($request, array $params = [], $method = "GET") {
        usleep(100000);

        $requestUri = HitBtcAPIConf::getAPIUrlSegment(HitBtcAPIConf::SEGMENT_TYPE_TRADING, $this->apiVersion)
                    . $request;
    Severity: Minor
    Found in src/tools/Request.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid variables with short names like $mt. Configured minimum length is 3.
    Open

            $mt = explode(' ', microtime());
    Severity: Minor
    Found in src/tools/Request.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $e. Configured minimum length is 3.
    Open

                        return array_filter($balances, function ($e) {
    Severity: Minor
    Found in src/HitBtcAPITrading.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $by. Configured minimum length is 3.
    Open

        public function getTrades($symbol, $by, $from, $startIndex = 0, $maxResults = 1000, $optionalParams = []) {
    Severity: Minor
    Found in src/HitBtcAPIPublic.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $ch. Configured minimum length is 3.
    Open

        private static $ch = null;
    Severity: Minor
    Found in src/tools/Request.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $e. Configured minimum length is 3.
    Open

                $e = curl_error(self::$ch);
    Severity: Minor
    Found in src/tools/Request.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $ch. Configured minimum length is 3.
    Open

            $ch = curl_init();
    Severity: Minor
    Found in src/tools/Request.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Method getTrades has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function getTrades($symbol, $by, $from, $startIndex = 0, $maxResults = 1000, $optionalParams = []) {
    Severity: Minor
    Found in src/HitBtcAPIPublic.php - About 45 mins to fix

      The method getBalances has a boolean flag argument $hideZeroBalances, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function getBalances($hideZeroBalances = false) {
      Severity: Minor
      Found in src/HitBtcAPITrading.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method json has a boolean flag argument $isDemoAPI, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public static function json($request, $apiVersion = 2, $isDemoAPI = false) {
      Severity: Minor
      Found in src/tools/Request.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '134', column '23').
      Open

                  throw new \Exception(
      Severity: Minor
      Found in src/tools/Request.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method getRecentTrades has a boolean flag argument $side, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function getRecentTrades($symbol, $maxResults = 1000, $formatItem = 'array', $side = true) {
      Severity: Minor
      Found in src/HitBtcAPIPublic.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method __construct has a boolean flag argument $isDemoAPI, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function __construct($apiKey, $apiSecret, $isDemoAPI = false) {
      Severity: Minor
      Found in src/HitBtcAPITrading.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '126', column '23').
      Open

                  throw new \Exception("Curl error: " . $e);
      Severity: Minor
      Found in src/tools/Request.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method __construct has a boolean flag argument $isDemoAPI, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function __construct($apiKey = null, $apiSecret = null, $apiVersion = 2, $isDemoAPI = false) {
      Severity: Minor
      Found in src/HitBTC.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method getAPIUrl has a boolean flag argument $isDemoAPI, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public static function getAPIUrl($apiVersion = 2, $isDemoAPI = false) {
      Severity: Minor
      Found in src/HitBtcAPIConf.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method __construct has a boolean flag argument $isDemoAPI, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function __construct($apiVersion = 2, $isDemoAPI = false) {
      Severity: Minor
      Found in src/HitBtcAPIPublic.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method __construct has a boolean flag argument $isDemoAPI, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function __construct($apiKey, $apiSecret, $apiVersion = 2, $isDemoAPI = false) {
      Severity: Minor
      Found in src/tools/Request.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Avoid unused private fields such as '$depositAddresses'.
      Open

          private $depositAddresses = null;
      Severity: Minor
      Found in src/HitBTC.php by phpmd

      UnusedPrivateField

      Since: 0.2

      Detects when a private field is declared and/or assigned a value, but not used.

      Example

      class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

      Severity
      Category
      Status
      Source
      Language