Sign upLogin

e-travel/agnostic_backend

View on GitHub
Star
lib/agnostic_backend/queryable/validator.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Class Validator has 32 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Validator < AgnosticBackend::Queryable::Visitor

      include AgnosticBackend::Utilities

      def initialize
Severity: Minor
Found in lib/agnostic_backend/queryable/validator.rb - About 4 hrs to fix

    Method visit_value has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

          def visit_value(subject)
        case subject.type
        when :integer
          unless subject.value.is_a?(Fixnum)
            subject.context.query.errors[subject.class.name] << value_error(subject)
    Severity: Minor
    Found in lib/agnostic_backend/queryable/validator.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method visit_value has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def visit_value(subject)
        case subject.type
        when :integer
          unless subject.value.is_a?(Fixnum)
            subject.context.query.errors[subject.class.name] << value_error(subject)
    Severity: Minor
    Found in lib/agnostic_backend/queryable/validator.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status